unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: soeren@soeren-tempel.net
Cc: 66296@debbugs.gnu.org, Mathieu Othacehe <othacehe@gnu.org>
Subject: [bug#66296] [PATCH v2] pack: Allow setting a custom image tag for Docker images
Date: Sun, 15 Oct 2023 16:11:59 +0200	[thread overview]
Message-ID: <87zg0k7z68.fsf@gnu.org> (raw)
In-Reply-To: <20231014094024.3993-3-soeren@soeren-tempel.net> (soeren@soeren-tempel.net's message of "Sat, 14 Oct 2023 11:38:56 +0200")

Hi,

soeren@soeren-tempel.net skribis:

> From: Sören Tempel <soeren@soeren-tempel.net>
>
> Previously, the image repository name was automatically computed from
> the packages in the manifest without allowing the user to set a custom
> one. As such, changing the packages in the manifest would result in a
> new image name. Thereby requiring updating documentation et cetera when
> using `docker load` directory on the resulting image.
>
> Inspired by `docker build -t`, this commit adds a new Docker-specific
> option to `guix pack` which allows setting a custom repository name for
> the resulting image. If this option is not specified, pack falls back
> to computing the name from the manifest. Therefore, this change is
> entirely backwards compatible.
>
> * guix/scripts/pack.scm (guix-pack): add --image-tag option
> * guix/scripts/pack.scm (%docker-format-options): new constant
> * guix/scripts/pack.scm (show-docker-format-options): new procedure
> * guix/scripts/pack.scm (show-docker-format-options/detailed): new procedure
> * guix/scripts/pack.scm (docker-image): allow setting a custom
>   repository name for the created docker image via extra-options.
> * doc/guix.texi (Invoking guix pack)[docker]: Document --image-tag option
>
> Signed-off-by: Sören Tempel <soeren@soeren-tempel.net>

It looks like commit 373ec2cf8ce97d5f89191c3d9211ee3a5c2067dc does not
include the pack.scm changes, only documentation.

Ludo’.




  parent reply	other threads:[~2023-10-15 14:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01 13:06 [bug#66296] [PATCH] pack: Allow setting a custom image tag for Docker images soeren
2023-10-14  8:23 ` Mathieu Othacehe
2023-10-14  9:38 ` [bug#66296] [PATCH v2] " soeren
2023-10-14 13:31   ` bug#66296: [PATCH] " Mathieu Othacehe
2023-10-15 14:11   ` Ludovic Courtès [this message]
2023-10-16  7:29     ` [bug#66296] [PATCH v2] " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg0k7z68.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=66296@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    --cc=soeren@soeren-tempel.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).