From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aEWPMRwvnGVzGgEAkFu2QA (envelope-from ) for ; Mon, 08 Jan 2024 18:21:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8A/UKxwvnGUQJgAAe85BDQ (envelope-from ) for ; Mon, 08 Jan 2024 18:21:32 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=H6RQDJqa; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704734492; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=T1ZZBvthXR4WGeTMxBOLzuLVQ3lvFaajSgkl2dNupC4=; b=RFGXLbJj0P++UOkG0rT3ipyOkqQuqTb2pqIbIul8lKvGC9HzaM/lfs/y0MeJ4TxnaAIJYA TX8BhCrdhDT91A3VXW+SGIfHRmOXpWson/eWmkICY8Gct3B3kD6p1Eza2RPJBJsBlF+U5j xYIFVJuRF0JWZQCgXiiD7UiRekTdaAhdAB984y4JUA5Ct5j+mvkHyXNPlqjSumIRF3mUqO 1EWv3X7E1/0oXwqosJX1v9aRsFqVruvZGPSC06jAxrKweATQIRQU216sxb9Q5Evd35ctDm enouK3QJowUHyCds5/Cx4tTZn3kYSMLWTWL70VjDmsaChUqwyIj/MfIOPNKdXA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704734492; a=rsa-sha256; cv=none; b=o4NIXfPCO7407TcnShTM37Q6Ty8WpCGH8wXmlb/S9hJGNHfS2/u2z6zzgJ7vJW0nRo9GZU UwIrGPP0zopDxI+3r870xRn3Atp58tONnknA7KTTB0soseE09Wu9L+K3Quv0TmLShOAbg0 wtB8n73e3VNLjWhOb9vX4ueeJ6EDBGwZxvEKc3icg45ilhPTvJWK5Y4QEOfUhM/wPxQ4CJ Dej9UbADrziQKjbaJMJqFpgWCdMpP2AouPGFTvGyH6ISv4L0ZVOhoOY6euLHw4rQbeqZGD uaq6Hj03sYrmamArU5b7wIqSieb5yegTJz8PD8eW3dSrm2uauLOHnYmYvf2mjw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=H6RQDJqa; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6363320A17 for ; Mon, 8 Jan 2024 18:21:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMtJ4-0005nB-VH; Mon, 08 Jan 2024 12:20:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMtJ3-0005mL-M3 for guix-patches@gnu.org; Mon, 08 Jan 2024 12:20:57 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMtJ3-0002KJ-D1 for guix-patches@gnu.org; Mon, 08 Jan 2024 12:20:57 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rMtJ9-0001d6-Bg for guix-patches@gnu.org; Mon, 08 Jan 2024 12:21:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67822] [PATCH v3] gnu: maths: petsc: Reduce closure size. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Jan 2024 17:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67822 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 67822@debbugs.gnu.org, Andreas Enge , Lars Bilke , Eric Bavier Received: via spool by 67822-submit@debbugs.gnu.org id=B67822.17047344326194 (code B ref 67822); Mon, 08 Jan 2024 17:21:03 +0000 Received: (at 67822) by debbugs.gnu.org; 8 Jan 2024 17:20:32 +0000 Received: from localhost ([127.0.0.1]:37449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMtId-0001bp-7E for submit@debbugs.gnu.org; Mon, 08 Jan 2024 12:20:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMtIY-0001bY-DM for 67822@debbugs.gnu.org; Mon, 08 Jan 2024 12:20:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMtIJ-000201-1W; Mon, 08 Jan 2024 12:20:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=T1ZZBvthXR4WGeTMxBOLzuLVQ3lvFaajSgkl2dNupC4=; b=H6RQDJqavTrAFJnq4FiT sYmVcIV8FZZopZjTNKH6dQyqtMNuGY6mpJ+cbIwr0Ohmz/VqDlHLtw4z7sJcLLI/miqVsbcRYpU1E r8dtJC1pKokWxFucvYIffnqF4vE8RcjrqQk7R4dOL/i/7tZ1m0FCv2YJa+0YDl8fmvEKAAs4gJcrR rqiN8WReoYslx4k/7NRDIw2Fdjl2IOjXrzztGwqbdnMWwzfZcjw5tNzo5xJGTnRFikmjMaXU9AzIR 79o2ZjzotFF0THPF/iMmPj4ZG7K8NqVjJTsSTGXsm+hW599EKEngIvDEAIRHe35gwvmZRhZOXv+CQ BqUKSgHnC56XNw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Efraim Flashner's message of "Sun, 7 Jan 2024 11:09:51 +0200") References: <9ba967c61c66acea4b4c3b1db6e1a446ad9e827e.1702558568.git.lars.bilke@ufz.de> <6a6413853ce16af65e143bd727715be6dd7d6048.1702630557.git.lars.bilke@ufz.de> <878r54f35z.fsf@gnu.org> <68C18595-278B-4AB1-9260-B154E7BC8E60@ufz.de> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 19 =?UTF-8?Q?Niv=C3=B4se?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Marbre X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 08 Jan 2024 18:20:07 +0100 Message-ID: <87zfxf3fp4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.01 X-Spam-Score: -7.01 X-Migadu-Queue-Id: 6363320A17 X-Migadu-Scanner: mx12.migadu.com X-TUID: Wso9LGYnu3h1 Hi, Efraim Flashner skribis: > On Fri, Jan 05, 2024 at 12:52:02PM +0100, Lars Bilke wrote: >> Hi Ludo, >>=20 >> On 5 Jan 2024, at 12:08, Ludovic Court=C3=A8s wrote: >>=20 >> > Can we instead patch the thing that creates =E2=80=98petscvariables=E2= =80=99 in the >> > first place? >> > >> > The reason I=E2=80=99m suggesting it is because in general we avoid ha= rdcoding >> > /gnu/store in substitution patterns because it=E2=80=99s possible to c= onfigure >> > Guix with a different store directory. >>=20 >> Thanks for your feedback! >>=20 >> In v1 of this patch I removed the 'petscvariables'-file completely but t= his broke dependent packages as well as not-yet packaged projects which use= the file for finding the PETSc library and configuriung their build system. >>=20 >> Is there a possibility to replace the hard-coded /gnu/store with a varia= ble which evaluates to the current store directory? > > There's %store-directory in (guix build utils). In fact, it looks like > git might have some code that you can borrow. Yes. However, I think we should use literal strings for patterns in =E2=80=98substitute*=E2=80=99. That is, I would avoid: (substitute* =E2=80=A6 (((string-append (%store-directory) "/bin/whatever")) =E2=80=A6)) in favor of, say: (substitute* =E2=80=A6 (("([[:graph:]]+)/bin/whatever") =E2=80=A6)) This is to make things easier to understand, 100% correct (in theory we should use =E2=80=98regexp-quote=E2=80=99 when turning strings into regexps= ), and to leave room for how =E2=80=98substitute*=E2=80=99 is implemented. Thanks, Ludo=E2=80=99.