unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tomas Volf <~@wolfsden.cz>
To: Skyler Ferris <skyvine@protonmail.com>
Cc: 69131@debbugs.gnu.org
Subject: [bug#69131] [PATCH 1/2] gnu: Add passt.
Date: Fri, 16 Feb 2024 22:19:54 +0100	[thread overview]
Message-ID: <87zfw0xg1x.fsf@wolfsden.cz> (raw)
In-Reply-To: <44375893-d991-49cf-a050-68ce493de299@protonmail.com> (Skyler Ferris's message of "Fri, 16 Feb 2024 03:02:43 +0000")

Skyler Ferris <skyvine@protonmail.com> writes:

> # Guix Style output (Minor repair)
> The tool made some reasonable-looking changes. I'm not sure if it would 
> be appropriate for me to add a new patch to this thread that applies 
> these changes.

I sent a v2 with some of the style changes applied.  It seems that
across guix the more common approach is to put (modify-phases) under the
#:phases keyword, and I prefer it.

In general I do not believe what `guix style' did to the (arguments) let
to more readable code, so I left it as it was.

I did adjust the (source) and (description) though.

>
> # Runs in a container with minimal inputs
> This package wants to use QEMU, and my machine is already a Xen guest. I 
> know that there are some complications when it comes to nested 
> virtualization. The demo script (at #$output/share/doc/passt/demo.sh) 
> did not "just work" for me, but it's not clear to me that this is a 
> problem with the package. I tried running it with the following:
>
> ```
> $ # Extra inputs are for the shell script
> $ ./pre-inst-env guix shell -C iproute2 coreutils util-linux-with-udev 
> passd
> [env]$ 
> /gnu/store/wgzlv2chrxmk4y4m4fxx8g7x0z59cb98-passt-2023_12_30.f091893/share/doc/passt/demo.sh
> ```

I tested the pasta binary instead using podman (--network=pasta), since
it was the reason I added this package in the first place.  It worked.




  reply	other threads:[~2024-02-16 21:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 19:17 [bug#69131] [PATCH 1/2] gnu: Add passt Tomas Volf
2024-02-14 19:19 ` [bug#69131] [PATCH 2/2] gnu: podman: Update to 4.9.3 Tomas Volf
2024-02-16  3:01   ` Skyler Ferris via Guix-patches via
2024-02-16 21:16     ` Tomas Volf
2024-02-16  3:03   ` Skyler Ferris via Guix-patches via
2024-02-16  3:02 ` [bug#69131] [PATCH 1/2] gnu: Add passt Skyler Ferris via Guix-patches via
2024-02-16 21:19   ` Tomas Volf [this message]
2024-02-16 21:14 ` [bug#69131] [PATCH v2 " Tomas Volf
2024-02-16 21:14   ` [bug#69131] [PATCH v2 2/2] gnu: podman: Update to 4.9.3 Tomas Volf
2024-03-02 16:25   ` bug#69131: [PATCH v2 1/2] gnu: Add passt Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfw0xg1x.fsf@wolfsden.cz \
    --to=~@wolfsden.cz \
    --cc=69131@debbugs.gnu.org \
    --cc=skyvine@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).