From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id wLnqDg1tHWYCOgEAqHPOHw:P1 (envelope-from ) for ; Mon, 15 Apr 2024 20:08:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wLnqDg1tHWYCOgEAqHPOHw (envelope-from ) for ; Mon, 15 Apr 2024 20:08:13 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=K+w3Q06B; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713204493; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hWue6cf8r6MECGGViNQp2lK8pvPZEuWZX5dVuOENq7g=; b=HiwTMIKHTKF7DCwo0PJ8mPkWwCFx5KydM15jwIO3s8/+Q4C4c4ibI/8tHGook+SUVyyHkL XRsMNDqnmjWWGs5h/ugjN8tP4HczgrkC44764EJOxr5pnw67O//UdKPbINzQHxpA1BhJgW mwzFWCNWhIzZzI4sRKU8msdvItMGYZU486jIvp4Lp1ec/s8xoCZy8pNleaK9GtmTZw2cqq Tdhj09UdIYk5RiYczb7GkEGLnb5BIiJ1nf/heiDzwnbmthZuHj2zuxBwGUyYWnN3B0TTnl LvnXYHbkEQATcws6B2AnAQuIo7VmKfbKvcdyLynoHrIDudjBJAtqLlv5saPSGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=K+w3Q06B; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713204493; a=rsa-sha256; cv=none; b=F1yxtSzZ8VHSpYftr2+A/dspn++b1BvW7hTQX6YdP7fRiRl79gq3qCxNJGbbIDvsUaoB+6 C8b4/47Ov3xkJHIrvq6roI/ABVNBCI9ZN0NK8Qu0z45gpteJjtJ2+D6S3KUjbSg9RePyoL 3abIdvo0Kpetj6sTIMIPwA52A/WsLm5nZjR7Jl26c8cic+N7mlty6T6yXun6/XyaAei6J3 wV7U6TEk8cy1l4m6o7A2IahNgMXpTUy2gnKl3APjjVFQlbB8oWsKRUoGxZ/OGqPxqn/uqE 4kvyCNG5tVDoPNk4zmBybKeSPARh+GZYosFniXCjdCirDTk8LGNLScU7LvG3Uw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B68E61AE5 for ; Mon, 15 Apr 2024 20:08:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwQkE-0003BK-4J; Mon, 15 Apr 2024 14:07:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwQkC-00039M-HM for guix-patches@gnu.org; Mon, 15 Apr 2024 14:07:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwQkC-0003uo-5n for guix-patches@gnu.org; Mon, 15 Apr 2024 14:07:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwQkN-00063p-MU for guix-patches@gnu.org; Mon, 15 Apr 2024 14:08:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70398] [PATCH 5/5] packages: Reduce code bloat due to list allocation in input fields. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Apr 2024 18:08:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70398 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ricardo Wurmus , Josselin Poiret , Mathieu Othacehe , Tobias Geerinckx-Rice , 70398@debbugs.gnu.org, Christopher Baines Received: via spool by 70398-submit@debbugs.gnu.org id=B70398.171320445223048 (code B ref 70398); Mon, 15 Apr 2024 18:08:03 +0000 Received: (at 70398) by debbugs.gnu.org; 15 Apr 2024 18:07:32 +0000 Received: from localhost ([127.0.0.1]:38764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwQjq-0005zU-8P for submit@debbugs.gnu.org; Mon, 15 Apr 2024 14:07:32 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:39021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwQjn-0005xy-78 for 70398@debbugs.gnu.org; Mon, 15 Apr 2024 14:07:28 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-346407b8c9aso1508271f8f.0 for <70398@debbugs.gnu.org>; Mon, 15 Apr 2024 11:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713204429; x=1713809229; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hWue6cf8r6MECGGViNQp2lK8pvPZEuWZX5dVuOENq7g=; b=K+w3Q06BsrLUxWxM5/YFptPTcgtRsSnCFKaujtdKX6X71z6rVXxFOFnB8abA20iRgH DyHkZxd5PO6FcqQ6QpLaYcPokDwyBhnIVpGGApHeMOOEgw2Nx+KiGz2GVlX/uok0muVW jzbyOzXb4OvXBc0h8Ps2CDFpaaXK7u6FJMGore8BnljGBGEKVyxINtVm35/NhPewV7LB 6EnQbGyvic96VJWtmClJU5jr4Cao4iGrhukT3hyCujYAMyVxMRRwuCb94AQfEvRdM72+ hai3Ta79VPPoc3q667AZY6mWH2ahCcJBpyb2w5lNOI+oCCa44nLpSWwtABeh8xF5dCpO 8kwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713204429; x=1713809229; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hWue6cf8r6MECGGViNQp2lK8pvPZEuWZX5dVuOENq7g=; b=nFVCwsUaCe0yvXsRC6NMDuupopXOU4qjjwrPbxeKn2Ul/x4QJgtBLGNtmYbfMuGJFM YoO0s/3MpQPo4kGd2wSw9Ur/55FJTQxvqRJHGv+JQFuxMSWeao/KPgfs0VIa/nrf/1gD EIbhUe23AB0k3FWg132y8la8lhquvGEsB+jLmgxOts3VymIcfXBU5cq5negldY7l76a0 PLLNw4PztDF6JTTVz+NXiEAyBe89Iq8qXobObKy9an/dPZrqRjxyHEYT5Weqdjmpd+m2 bppQBzut1ZeILuAURfj1uZJQsnX7nlobVXeKl1A83Gjar7Ty8CnJqKZlBNWAm9mv27Ed exDw== X-Gm-Message-State: AOJu0YyWFkhCDuiHFj6cgw3jJtBCzClYjTugvoltlfXE2fDg4nsxy5iQ 39drOEl8lPlcU5BNNXIJiy9YXNs35bjLkOaAwwAk0erLTHu8NxxL X-Google-Smtp-Source: AGHT+IE/sh82i9bxq+xirUwm2iqrKxNEzS5G4lqGjOwNRbQiotvhedIEEWvIhW63goDr6GtOoQdAYA== X-Received: by 2002:a05:600c:474a:b0:417:29a3:3f4f with SMTP id w10-20020a05600c474a00b0041729a33f4fmr7859849wmo.2.1713204429104; Mon, 15 Apr 2024 11:07:09 -0700 (PDT) Received: from lili (roam-nat-fw-prg-194-254-61-40.net.univ-paris-diderot.fr. [194.254.61.40]) by smtp.gmail.com with ESMTPSA id k21-20020a05600c1c9500b004182a36b185sm9785647wms.2.2024.04.15.11.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 11:07:08 -0700 (PDT) From: Simon Tournier In-Reply-To: ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 15 Apr 2024 17:37:07 +0200") References: Date: Mon, 15 Apr 2024 19:56:08 +0200 Message-ID: <87zftuik7b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.90 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -3.90 X-Migadu-Queue-Id: 1B68E61AE5 X-TUID: 1rVnUe33Mqlb Hi Ludo, On lun., 15 avril 2024 at 17:37, Ludovic Court=C3=A8s wrote: > + ((_ (list args ...)) > + ;; As of 3.0.9, (list ...) is open-coded, which can lead to a long = list > + ;; of instructions. To reduce code bloat in package modules where = input > + ;; fields may create such lists, move list allocation to the callee. > + (add-input-labels args ...)) I am not sure to understand: =C2=AB (list ...) is open-coded, which can lead to a long list of instructions. =C2=BB. Well, irrelevant for .go size but why not something like: ((_ (list args . rest)) (apply add-inputs-labels (append args rest))) It would not change for .go size but it would change for run-time if it=E2=80=99s a long list, no? Cheers, simon