From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id COzeMQwcX2aLOwAAA41jLg (envelope-from ) for ; Tue, 04 Jun 2024 15:52:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UArwLQwcX2aFKQAA62LTzQ (envelope-from ) for ; Tue, 04 Jun 2024 15:52:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JZHvlkd2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717509132; a=rsa-sha256; cv=none; b=ENQPASv+eh7cpcp4Ty8RwSjMpG/cYcjYzPRgT7/Pt4Crlz3khKrobnkyhcxXtWtmbZwdQ3 l5ZqU+vVKIGMjtTnNDPRy3dHetqVS2lN9AmQurtrVd8s4tGuUtUMR2G3XLek76K5DtCckz m0YVoMyTHrQaJMpVddLFo921HqSujtJBs3nzxSWKePYJZgVweYzt+N/gRV4YJw0yIc3mdh WKg0YVo5riKgRMlhvVEn8tJB/1vdtYcptrBBQNZMksWQmb3lXCsIin95SE2Q8HjA93DAGU v+sujKgcdsohAXbYYvbP/NnqlwJyVWIrhHPDwDd1R56QXAigaXVUz9MXII+UsQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JZHvlkd2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717509132; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/dzdluFHBtpupsgP4+H8Q/95Rvg6ujUtcrzE6OzDDdc=; b=UZe/4kD4RpIR1ZzAE/sUPPxS9W8Ublw6iRYIpilsuvRebxJaHN1E3pMT3r9BfZB/safMjI XoKLHPyrhWx2z0feV1trG7Id38nmwms2Vz0rpcV/W4xBJt4cF119aaAyzYuMUaHvdUyqgx 5vFvJxnBPIA4vq34ZZxK8aahcJYPx9/lb5T9DiMEzDCN5ySrgkjzicIiKA2CK/TILfjkNN 1oiR5+ZRqJE5TksLi1vnX4b/xsSO/19IUdudBLPQc8RECz98veeUr5RT/eRA0mFkxMOC8/ TznWR/KCoN6wUZWBR57cukKgH6+P0dvkFAhdLpunAAm6U6z7ctvZKVu3qVp2VA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 106BD1F8F2 for ; Tue, 4 Jun 2024 15:52:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEUYs-0000t9-H9; Tue, 04 Jun 2024 09:50:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEUYr-0000ry-G0 for guix-patches@gnu.org; Tue, 04 Jun 2024 09:50:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEUYr-0003z7-7b for guix-patches@gnu.org; Tue, 04 Jun 2024 09:50:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEUZ4-00038h-CZ for guix-patches@gnu.org; Tue, 04 Jun 2024 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71324] [PATCH] news: Add entry for 'docker-service-type' changes. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 Jun 2024 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71324 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Carlo Zancanaro Cc: Julien Lepiller , "pelzflorian \(Florian Pelz\)" , 71324@debbugs.gnu.org Received: via spool by 71324-submit@debbugs.gnu.org id=B71324.171750905912054 (code B ref 71324); Tue, 04 Jun 2024 13:51:02 +0000 Received: (at 71324) by debbugs.gnu.org; 4 Jun 2024 13:50:59 +0000 Received: from localhost ([127.0.0.1]:51729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEUZ0-00038I-0W for submit@debbugs.gnu.org; Tue, 04 Jun 2024 09:50:58 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:39657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEUYx-00037t-V0 for 71324@debbugs.gnu.org; Tue, 04 Jun 2024 09:50:56 -0400 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-35dca51a5b1so261111f8f.2 for <71324@debbugs.gnu.org>; Tue, 04 Jun 2024 06:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717508977; x=1718113777; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/dzdluFHBtpupsgP4+H8Q/95Rvg6ujUtcrzE6OzDDdc=; b=JZHvlkd2JK8Rjic+UXbjsBnHOBRTxO0DLbKHUS3cWUm5nvkhq6Qbf2x10t7gTjgQBq PcfCCZU/34tF80+lbEpnXQBML0BwARIm7RPS5W+3WbptxaC6rGFfYIcTrPrgP1vniS/E DNnGdo4hA1EsFG8QFcbDv3YpXtzPV6xl9/GYSAqpZ5Fd+s5am8fSJbqL2cYu7xnOtpqW /eAPRLopnwZE3SZxdQBPZyTXoAdK5hH+N2BHSYNGhdTidcygUKUdni1KoN7qEGZZpzaB C9bGBQcg+Py0Y76f0RLFk5qrEQeiPrO8glvULZLJVrG8lfKaVTNa0rjzIW/ia2e218+/ CRpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717508977; x=1718113777; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/dzdluFHBtpupsgP4+H8Q/95Rvg6ujUtcrzE6OzDDdc=; b=jRqIT+q/LR2Q/fIaSHLxcLe5UWSFw+OGXukkykFVOqy1CyKXkFMMMna8dlNlhov9ow zCf0+iFR874CzVy6JC1K6iPAq0N8NABEztY/k/rPG+BPzlArjK3BHYksM5Zi2JrfZNe4 32msN92FoNyeyxhC9Hok5dqrJKQ427zgRNrCQDh6g6jzsvO3N5V0i2b7rIMp+LmxLYs1 mWBVQOrT6FozhYcbWzYQdf/fxgo6vqML1t1hMNGXaihfi3AmZZC/RlxphCUwp9vXDWA/ l73uT8j2EOQCQAkwAp0UFddu+Bf8qeLONtl4/Szbpkydsm5CxA5HbGHYwNA9eMxunJoK fdEQ== X-Forwarded-Encrypted: i=1; AJvYcCUfyCN1w5vw4ysa6ZQ7ET2OcavMVrsV1z1SylZJ6SZhJvQdh3gXFj3BphdZtU17bwgDXDJdTSn+pbcfnx4jCm9nDbpp6Fk= X-Gm-Message-State: AOJu0YxNovtsBLG3a48bTuV4GqxWeyKGI5i3CqXkwBE66v3dNIV8x3ek mc3oO3SVfKlvU+ULLTegkjBHH1VYC6ZJpOviI1/KtiPleGXEBDUQN7wIaQ== X-Google-Smtp-Source: AGHT+IFN1u+B23VFv2ijItY6Xm9rjx7YSIsFXb/A17qMehz/CoTbBTAJS32l6V4OS3xC7AyINgXqgA== X-Received: by 2002:a19:e054:0:b0:51f:40a6:234a with SMTP id 2adb3069b0e04-52b896c4bf2mr7167488e87.4.1717508471691; Tue, 04 Jun 2024 06:41:11 -0700 (PDT) Received: from localhost ([93.100.15.190]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b97da6171sm749550e87.49.2024.06.04.06.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 06:41:11 -0700 (PDT) From: Oleg Pykhalov In-Reply-To: <87zfs13qth.fsf@zancanaro.id.au> (Carlo Zancanaro's message of "Tue, 04 Jun 2024 21:11:54 +1000") References: <0ec66ae6dac10ef005782e8a1e9245b57e10d9d4.1717334243.git.go.wigust@gmail.com> <87wmn6cr1i.fsf@pelzflorian.de> <87y17mjd6j.fsf@gmail.com> <87zfs13qth.fsf@zancanaro.id.au> Date: Tue, 04 Jun 2024 16:41:10 +0300 Message-ID: <87zfs0g70p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 106BD1F8F2 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 0.56 X-Spam-Score: 0.56 X-TUID: i/1MlSzJhRPZ --=-=-= Content-Type: text/plain Hello Carlo, Thank you for your thoughtful review and valuable suggestions. Carlo Zancanaro writes: > On Mon, Jun 03 2024, Oleg Pykhalov wrote: >> Every docker-service-type user will need to add containerd-service-type >> to their system configurations, otherwise a message about not any >> service provides containerd will be displayed during reconfigure. > > Is this necessary? If I understand correctly, the docker service has a > hard dependency on containerd, so having to specify it every time is > unnecessary boilerplate. Could we add an extension for containerd that > does nothing, but which the docker service can use just to request its > inclusion? Something like: Technically, Docker relies on a container runtime, not specifically limited to containerd. While containerd is a popular choice, there are alternative runtime options available as well. > (define containerd-service-type > (service-type (name 'containerd) > (description ...) > (extensions ...) > ;; Declare an extension point, so containerd can be requested > ;; by other services without affecting its configuration. > (compose (const #t)) > (extend (lambda (config _) config)) > (default-value (containerd-configuration)))) > > (define docker-service-type > (service-type ... > (extensions > ... > (service-extension containerd-service-type (const #t))))) > > That way users could instantiate containerd themselves if they need some > particular configuration, but if not it would be pulled in automatically > by the docker service. Hopefully this would cause less of an issue for > existing configs that don't use a custom containerd (like mine). Will this mechanism support the use of different container runtimes? > We could even, for backwards compatibility, allow the docker service > type to pass through the containerd package from its old configuration > (while printing a warning). This could make it possible to separate > containerd from docker without breaking any existing configurations. If I understand correctly, could we potentially prevent users from needing to provide the containerd-service-type and instead issue a warning that they will need to provide it in the future? I believe this would be a great solution, but I couldn't locate it while writing this patch. Regards, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmZfGXYUHGdvLndpZ3Vz dEBnbWFpbC5jb20ACgkQFn+OpQAa+pzDjQ/+Jsx8LqEmC12vve2D/5r+AidLZiO7 A3ZP7OzOsYdYjlNVUjaPHl0oDVaywSx7ocoZHx/R5UC2B4G8nPSdrN61RLJirsOe rbrJ7Cetbmilfu8svoE8Tjh5x7RDox2of9JJ0J3lTKGN1WjK7DOUez+2BKki3UAI uSQ4LtuPZ0QPx4uFFquLsnxQ8t77XjlMyLLtVGkCpPBTzTu/Is61FCe5W6G6mnEo Ic5df6PITl8Jyc4frQ8sByqIiRcBAM6CebS+X2LzL55Hfq2a1IXQOoG0MlRA13MB FBYx2Ap+k5WQK+tRsiQp6XMI9r++/9Z9YUTpL0cDz0QrTb+vbTRw4Rnh/KEvJ3uM 70HrazWdRN+qCM2vbLBJopr1IiikahCYWaKchlSHGZRJEvMVOxMJEj4ykElQJfxT cDWxgJICvl6R0rFMXMPUVu0TY3O/nVGCM0M2haZeiE7C5plHUKCOEvrOuNeQYRay 4P3YDIAi2gkrAmN3nn1WqIXdMocRESGE3jMIdB/fTi7kZiPluhzvgyA34SJCCJHs Hr41rv0Tn5KO3ubH/r7jiLerBkN6RuJELHxLBU+XRs6FPUd0GS6c3/ya7TwNVV1f FxqEEpxRHAs90L+avSUTp9HPnR3aQLgqtmcMIYdFsu4TXRjy8TC5I56QfM2O+fJX xBQX89foOIXbG4s= =WAtb -----END PGP SIGNATURE----- --=-=-=--