From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id cJogOY29cmalogAA62LTzQ:P1 (envelope-from ) for ; Wed, 19 Jun 2024 11:14:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id cJogOY29cmalogAA62LTzQ (envelope-from ) for ; Wed, 19 Jun 2024 13:14:22 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=eJ1Bkjv3; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718795661; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Sh25J7lzO1vgD0TF0NTHiCKm2MT2O94paKPq1fSk4gs=; b=cjQrIzfgGvMKatHJOmFoX9ZAkMkSUXhWgEevoXTOK1O0YCQ1HB2lODYx7KIoWXFAK0f9Z9 5yalblAtrDmBPcCBXl7Cy+nDdAMtJu0QFg9/Vv5RDyOb6kjqVTyozJzxdgHuy2utv6BsEo r0v/51cpj2f9wX+ewIZ2gKRNm1KW1Obt+q0LFsPanKsSSWM1spX7+62lHLiisHuXtY50dB r0pvFqnKuYDO9PJcQwKRpTEgFj7gsZdtPs7XE0fVGwx8wJHvWtdllx4lnhP5jc+8JToumN gMgY9XNx1on59RB9IkMxFydapBjGtsDf8QAO4BUMG1yJc++7qcfajuzupiGvDw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=eJ1Bkjv3; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718795661; a=rsa-sha256; cv=none; b=HFxQF8xqaJEsVLWcywBu2gwmmE4hokdtgjUySXyjppQGoDbZUwgb7W+qN4b+RGAXPWj4Af njT7stom0eVAQHvrePxQ88BlVE4V16o0KZc+h7L8h8cDORJPDczuIs8vMkkAQ2jq4+Sf36 q5pMkMAlfuz7ZzXlHSRc8bXHsTze5MVFxyqOjYaaRZUyfUN9XhFLNivGx3lYKpzhOogQev Kcxfnt/Z1bA2PR0SfMp+2AtoUhJe4DxtO7HZAtoCWyjtwg0dsHcN456sB4zt8M7nF3w/h7 QkKaYexBEWjdPRA3AuK+peQTggD9pT72fIv01FfGZwVbX+vz2qSWEH2SWpa+Jg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 221693F4FA for ; Wed, 19 Jun 2024 13:14:21 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJtGO-0002Qc-TB; Wed, 19 Jun 2024 07:14:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJtGL-0002Pz-Rl for guix-patches@gnu.org; Wed, 19 Jun 2024 07:14:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJtGK-0007Ek-DF for guix-patches@gnu.org; Wed, 19 Jun 2024 07:14:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJtGM-0001XY-7w for guix-patches@gnu.org; Wed, 19 Jun 2024 07:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71319] [PATCH v2 1/3] gnu: emacs-ddskk: Update to 17.1 revision 0. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Jun 2024 11:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71319 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: gemmaro Cc: 71319@debbugs.gnu.org, Katherine Cox-Buday , Liliana Marie Prikler , Andrew Tropin Received: via spool by 71319-submit@debbugs.gnu.org id=B71319.17187955865842 (code B ref 71319); Wed, 19 Jun 2024 11:14:02 +0000 Received: (at 71319) by debbugs.gnu.org; 19 Jun 2024 11:13:06 +0000 Received: from localhost ([127.0.0.1]:40211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJtFR-0001WA-N6 for submit@debbugs.gnu.org; Wed, 19 Jun 2024 07:13:05 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:44176 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJtFO-0001Va-TT for 71319@debbugs.gnu.org; Wed, 19 Jun 2024 07:13:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1718795570; bh=AwOJV85uxRuOlwEJBwGPg90BDRniyEI9Tsfv7BznLIc=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=eJ1Bkjv3Mvti+AI2cW2n5csi4/u+jUKwMzJhfsYjgLwmDP2m6LOhgDeEYIupvEncq ey8TylTMZGav8Ysq/bZ1uyonlAKHCu7MPAXR42gMAiUZDji9nJfjd5TH17vgTXWzay vcrWnN1l+Z5O4fTuoz1SrLh2WbpThINaYAqv++Yg= Received: by b221-5.in.mailobj.net [192.168.90.25] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 19 Jun 2024 13:12:50 +0200 (CEST) X-EA-Auth: kl2OGkXj0rhnmh163NWAu7f+Bqldu6iZvyTGVyi7jThYqDflCAUT5FDQlZaHrC8qO/4k/vcIVbt4vBmh5WDCQ7+sceXuaxNRuT9aTcqY32E= In-Reply-To: <4328ea3c1b2e79691a6ed1d76e21688a5452f410.1718104831.git.gemmaro.dev@gmail.com> (gemmaro's message of "Tue, 11 Jun 2024 20:20:29 +0900") References: <4328ea3c1b2e79691a6ed1d76e21688a5452f410.1718104831.git.gemmaro.dev@gmail.com> Date: Wed, 19 Jun 2024 13:12:33 +0200 Message-ID: <87zfrh425a.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 221693F4FA X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -5.36 X-Spam-Score: -5.36 X-TUID: Ly6uGig6yWML Hello, gemmaro writes: > * gnu/packages/emacs-xyz.scm (emacs-ddskk): Update to 17.1 revision > 0 (commit 8c47f46). Thank you. Some comments follow. > (define-public emacs-ddskk > - ;; XXX: Upstream adds code names to their release tags, so version and code > - ;; name below need to be updated together. > + ;; XXX: Upstream adds code names to their release tags, so version > + ;; and code name need to be declared and updated together when the > + ;; next version is released (e.g. "Neppu" in 17.1.) Since you're moving the package away from code names, you should also remove references to them in the comment above. I.e., we just use cherry-picked commits instead of tags. > (let ((version "17.1") > - (code-name "Neppu")) > + (commit "8c47f46e38a29a0f3eabcd524268d20573102467") > + (revision "0")) > (package > (name "emacs-ddskk") > - (version version) > + (version (git-version version revision commit)) You can replace version above with "17.1" and remove the binding above, as it is usually done. Regards, -- Nicolas Goaziou