unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Romain GARBAGE <romain.garbage@inria.fr>
Cc: 71938@debbugs.gnu.org, 44518@debbugs.gnu.org
Subject: [bug#71938] [PATCH] gnu: Add matterhorn.
Date: Sun, 07 Jul 2024 01:07:25 +0200	[thread overview]
Message-ID: <87zfqurufm.fsf@elephly.net> (raw)
In-Reply-To: <20240704103616.32655-1-romain.garbage@inria.fr> (Romain GARBAGE's message of "Thu, 4 Jul 2024 12:36:16 +0200")

Hi Romain,

> * gnu/packages/haskell-apps.scm (matterhorn): New variable.
> * gnu/packages/haskell-crypto.scm (ghc-crypton, ghc-crypton-x509,
> ghc-crypton-x509-store, ghc-crypton-x509-system,
> ghc-crypton-x509-validation, ghc-tls-1.9): New variables.
> * gnu/packages/haskell-web.scm (ghc-crypton-connection,
> ghc-mattermost-api, ghc-mattermost-api-qc, ghc-modern-uri): New variables.
> * gnu/packages/haskell-xyz.scm (ghc-aspell-pipe, ghc-bimap,
> ghc-checkers, ghc-monad-parallel, ghc-text-zipper-13, ghc-stm-delay,
> ghc-unique, ghc-unix-compat-7, ghc-vty-6, ghc-vty-crossplatform,
> ghc-vty-unix, ghc-hclip, ghc-brick, ghc-brick-skylighting): New variables.

thank you for the patch!  This looks all pretty good.

There are a few minor quibbles:

* Please make one commit for every added package.
* matterhorn: Please sort inputs alphabetically.
* ghc-crypton: please use Texinfo syntax such as @itemize for the list
  of features.
* ghc-crypton-x509: it would be good to know if there is something we
  can do to make tests pass.  If the tests are pointless it would be
  good to record that.  Please also make sure that the description is
  ... descriptive.
* ghc-tls-1.9, ghc-unix-compat-7, ghc-vty-6, ghc-text-zipper-13: Is it
  desirable to have these packages instead of upgrading the existing
  packages?  Is there pending work on the Haskell team branch(es) that
  would make the use of these versioned variants obsolete?
* Please check whether potentially unwanted changes should really be
  included, such as the cosmetic changes to ghc-githash.

I also just found that there's an old patch set for matterhorn; I cc'd
the issue email address.

-- 
Ricardo




  reply	other threads:[~2024-07-06 23:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 10:36 [bug#71938] [PATCH] gnu: Add matterhorn Romain GARBAGE
2024-07-06 23:07 ` Ricardo Wurmus [this message]
2024-07-09  9:02   ` [bug#44518] " Romain GARBAGE
2024-07-09 13:53 ` [bug#71938] [PATCH v2 00/25] Add matterhorn package Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 01/25] gnu: Add ghc-crypton Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 02/25] gnu: Add ghc-crypton-x509 Romain GARBAGE
2024-07-09 13:53     ` [bug#71938] " Romain GARBAGE
2024-07-09 13:53   ` [bug#71938] [PATCH v2 03/25] gnu: Add ghc-crypton-x509-store Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 04/25] gnu: Add ghc-crypton-x509-system Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 05/25] gnu: Add ghc-crypton-x509-validation Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 06/25] gnu: Add ghc-tls-1.9 Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 07/25] gnu: Add ghc-crypton-connection Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 08/25] gnu: Add ghc-mattermost-api Romain GARBAGE
2024-07-09 13:53   ` [bug#71938] [PATCH v2 09/25] gnu: Add ghc-mattermost-api-qc Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 10/25] gnu: Add ghc-modern-uri Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 11/25] gnu: Add ghc-aspell-pipe Romain GARBAGE
2024-07-09 13:53   ` [bug#71938] [PATCH v2 12/25] gnu: Add ghc-bimap Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 13/25] gnu: Add ghc-checkers Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 14/25] gnu: Add ghc-monad-parallel Romain GARBAGE
2024-07-09 13:53   ` [bug#44518] [PATCH v2 15/25] gnu: ghc-text-zipper: Update to 0.13 Romain GARBAGE
2024-07-09 13:54   ` [bug#44518] [PATCH v2 16/25] gnu: Add ghc-stm-delay Romain GARBAGE
2024-07-09 13:54   ` [bug#71938] [PATCH v2 17/25] gnu: Add ghc-unique Romain GARBAGE
2024-07-09 13:54     ` [bug#44518] " Romain GARBAGE
2024-07-09 13:54   ` [bug#44518] [PATCH v2 18/25] gnu: Add ghc-unix-compat-7 Romain GARBAGE
2024-07-09 13:54   ` [bug#71938] [PATCH v2 19/25] gnu: Add ghc-vty-crossplatform Romain GARBAGE
2024-07-09 13:54   ` [bug#71938] [PATCH v2 20/25] gnu: Add ghc-vty-unix Romain GARBAGE
2024-07-09 13:54   ` [bug#44518] [PATCH v2 21/25] gnu: Add ghc-vty-6 Romain GARBAGE
2024-07-09 13:54   ` [bug#44518] [PATCH v2 22/25] gnu: Add ghc-hclip Romain GARBAGE
2024-07-09 13:54   ` [bug#71938] [PATCH v2 23/25] gnu: Add ghc-brick Romain GARBAGE
2024-07-09 13:54   ` [bug#71938] [PATCH v2 24/25] gnu: Add ghc-brick-skylighting Romain GARBAGE
2024-07-09 13:54   ` [bug#44518] [PATCH v2 25/25] gnu: Add matterhorn Romain GARBAGE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfqurufm.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=44518@debbugs.gnu.org \
    --cc=71938@debbugs.gnu.org \
    --cc=romain.garbage@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).