From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id oDquCDba+mYfuQAA62LTzQ:P1 (envelope-from ) for ; Mon, 30 Sep 2024 17:04:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id oDquCDba+mYfuQAA62LTzQ (envelope-from ) for ; Mon, 30 Sep 2024 19:04:54 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="aM/z4kvQ"; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=I+6TICrJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727715894; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7/3kTBK8ajgvFEXkVzHPKZBG4vGxEOHXKsmIw4NHFBQ=; b=JG4aVbmc4JGln6ejsFHN1r7wyLCa3n1ZZanU9r6dzmhk80qs/x/KtNs2rx9UcSiHdouilq Nr+0DiP5m+gqmFXN6YSYVN98rTNnyELsQ0ewFejdg00ur7EyjRS3W8Jn0JB2lHeBRToUZF mrYhM6hFlXfjBusf6fWZBp3q3JWsH/JRnKCEGuwmB1ZOVt0Xc8kWwjBrXqvttw1l0ccPMF yBsj0VP7eQ1ADauE9RwGtcEV1Do7HokwavuV6iO6uIOV9uqm4OA9MkNDs/UgnBaZt/J1S8 G8CrqioZeXkcfv5T6i9QxnmbRh77dhiJOo4Tz0BMRB0r5JRGubwX34MFxnTv/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="aM/z4kvQ"; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=I+6TICrJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727715894; a=rsa-sha256; cv=none; b=B3TcBWCYOP9wQyF6p4/D8Kb/xVoKQEyolXBJ0NezyyBEdmYa+Hdj32Hydbq3HDYgmTBQ9l SKIYuwoTyQrHLMYj5NKbtBpufSLnIElOACf76p51z4Oie1otVzlmXN0QLtnRjl3/+E0t2C 7wKeXm/EPufJw/yAth2o9uSzjvc3C5s823PgCSiF7MQx8XfgaDorOV3JZXZCxQbIB78C5b de1o+TRSQqXq7EpwAD/XskL2yncFAdhMWGcMAJhvV6JhQ2lmkDjl7BqPxWBj7SaGB74DRn u451X/LWSdp9xc4jV01Pg8/kW+b48hzdhpz/Nok05RuWJa0lfZsfviSm1//p9A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E087C1BDC1 for ; Mon, 30 Sep 2024 19:04:53 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svJp6-0005xA-SN; Mon, 30 Sep 2024 13:04:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svJoz-0005vp-Sm for guix-patches@gnu.org; Mon, 30 Sep 2024 13:04:29 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svJoz-0000cS-K1 for guix-patches@gnu.org; Mon, 30 Sep 2024 13:04:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=7/3kTBK8ajgvFEXkVzHPKZBG4vGxEOHXKsmIw4NHFBQ=; b=aM/z4kvQEPq0a2unf013tp+Rmisl/Wx65tUz6pugdl9i4ta8lsofeHRVYXPrGhRbcQRr0rs3MLdeUg40GJCaA3PmwMUlCBZbayZ5o4vuRDxK7kt/kjzPJPis253fEFLluilK4A/wlUMszh2GOniSDEiuvc9nWDVDMeRn+Qg/lRHmq6sjKijvSXa+PW6IkvuTdIrBkPMfvSaVeucRWDwvtuP00KDcCkAWJAWEQcU7J9SnHTQ6JjHHzCkNIgl/2g/13smWZwZ0/dvk0AZLqVUO2Quf38oIxGqFesrGawWpHRpMvF796nRKppW/m67Yg/lo7UPn/ej/h2PK/Djqao+Zlg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svJpW-0006Kh-FO for guix-patches@gnu.org; Mon, 30 Sep 2024 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73260] Add libguestfs Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Sep 2024 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73260 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Giacomo Leidi Cc: 73260@debbugs.gnu.org Received: via spool by 73260-submit@debbugs.gnu.org id=B73260.172771589224280 (code B ref 73260); Mon, 30 Sep 2024 17:05:02 +0000 Received: (at 73260) by debbugs.gnu.org; 30 Sep 2024 17:04:52 +0000 Received: from localhost ([127.0.0.1]:45892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svJpK-0006JD-1B for submit@debbugs.gnu.org; Mon, 30 Sep 2024 13:04:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svJpC-0006H3-HD for 73260@debbugs.gnu.org; Mon, 30 Sep 2024 13:04:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svJoY-0000Yq-MW; Mon, 30 Sep 2024 13:04:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=7/3kTBK8ajgvFEXkVzHPKZBG4vGxEOHXKsmIw4NHFBQ=; b=I+6TICrJd2Foewyf0boj 2FSuM0n6AcVQYC1Q8HepO2piu/UwCvwboNM7vWdNwsJc3yPwZ52ggjs5tlGuYLaAP2lJMc5NhAeeo 0DqiQbR2maJQqJyGgfbBzrPHub5hZMTm+mCST3dtbXVnH40aaUo4jf4vTZoIp7syTn074WA1K2ecz b+N7o/22wmTQvlYV+sWEbK3dTmsvJG/Q/t65jeXl2vZryPeSeETuLALkOzNaftxx9a89U31S5rrxW Npoor+Nqy19V+8yagJoojgqZPpsSWhPPY/ullKPtoYC8tMuEs4g2ScY3PFNmxHYggvmPOAsAYtF02 Ck7/e1/COunj2Q==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <247263a340d7dedbf4671ebaf75da540e7e62734.1726348858.git.goodoldpaul@autistici.org> (Giacomo Leidi's message of "Sat, 14 Sep 2024 23:20:56 +0200") References: <0e7f7cc7-b6b8-0c97-f175-edd6d85a2eb1@autistici.org> <247263a340d7dedbf4671ebaf75da540e7e62734.1726348858.git.goodoldpaul@autistici.org> Date: Mon, 30 Sep 2024 19:03:59 +0200 Message-ID: <87zfnp5b0g.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -4.00 X-Spam-Score: -4.00 X-Migadu-Queue-Id: E087C1BDC1 X-TUID: vCnk5Lx+t+yc Hi, Giacomo Leidi skribis: > * gnu/packages/virtualization.scm (hivex): New variable. > > Change-Id: I9828d267d5c6f24dc5039ea3b1849248cd9d23fb [...] > + #:configure-flags > + #~(list > + "--disable-static" > + "--with-readline" > + "--disable-rpath") Please keep it on one line. > + #~(modify-phases %standard-phases > + (replace 'bootstrap > + (lambda _ > + (invoke "autoreconf" "-vif"))) I expect this to be unnecessary: isn=E2=80=99t that equivalent to the defau= lt =E2=80=98bootstrap=E2=80=99 phase? > + (add-before 'install 'set-rpath > + (lambda _ > + (for-each > + (lambda (sofile) > + ;; The =E2=80=98validate-runpath=E2=80=99 phase fails t= o find libhivex.so.0. > + (invoke (string-append #$(this-package-native-input "pa= tchelf") > + "/bin/patchelf") > + "--add-rpath" (string-append #$output "/lib") s= ofile)) > + '("perl/blib/arch/auto/Win/Hivex/Hivex.so" > + "ruby/ext/hivex/_hivex.so")))) As a rule of thumb, when building from source, better arrange to pass the right =E2=80=98-Wl,-rpath=3D=E2=80=A6=E2=80=99 flags to the compiler th= an resorting to PatchELF (PatchELF is useful when dealing with prebuilt binaries). In this case, could you tweak the build system to pass =E2=80=98-Wl,-rpath=3D(string-append #$output "/lib")=E2=80=99 when buildin= g these two shared libraries? > + (license license:lgpl2.1))) Please double-check whether it=E2=80=99s really explicitly =E2=80=9Cv2.1-on= ly=E2=80=9D. By default, it=E2=80=99s =E2=80=9Cor any later version=E2=80=9D, meaning =E2= =80=98lgpl2.1+=E2=80=99. Thanks, Ludo=E2=80=99.