From: "Ludovic Courtès" <ludo@gnu.org>
To: Giacomo Leidi <goodoldpaul@autistici.org>
Cc: 73260@debbugs.gnu.org
Subject: [bug#73260] Add libguestfs
Date: Mon, 30 Sep 2024 19:03:59 +0200 [thread overview]
Message-ID: <87zfnp5b0g.fsf_-_@gnu.org> (raw)
In-Reply-To: <247263a340d7dedbf4671ebaf75da540e7e62734.1726348858.git.goodoldpaul@autistici.org> (Giacomo Leidi's message of "Sat, 14 Sep 2024 23:20:56 +0200")
Hi,
Giacomo Leidi <goodoldpaul@autistici.org> skribis:
> * gnu/packages/virtualization.scm (hivex): New variable.
>
> Change-Id: I9828d267d5c6f24dc5039ea3b1849248cd9d23fb
[...]
> + #:configure-flags
> + #~(list
> + "--disable-static"
> + "--with-readline"
> + "--disable-rpath")
Please keep it on one line.
> + #~(modify-phases %standard-phases
> + (replace 'bootstrap
> + (lambda _
> + (invoke "autoreconf" "-vif")))
I expect this to be unnecessary: isn’t that equivalent to the default
‘bootstrap’ phase?
> + (add-before 'install 'set-rpath
> + (lambda _
> + (for-each
> + (lambda (sofile)
> + ;; The ‘validate-runpath’ phase fails to find libhivex.so.0.
> + (invoke (string-append #$(this-package-native-input "patchelf")
> + "/bin/patchelf")
> + "--add-rpath" (string-append #$output "/lib") sofile))
> + '("perl/blib/arch/auto/Win/Hivex/Hivex.so"
> + "ruby/ext/hivex/_hivex.so"))))
As a rule of thumb, when building from source, better arrange to pass
the right ‘-Wl,-rpath=…’ flags to the compiler than resorting to
PatchELF (PatchELF is useful when dealing with prebuilt binaries).
In this case, could you tweak the build system to pass
‘-Wl,-rpath=(string-append #$output "/lib")’ when building these two
shared libraries?
> + (license license:lgpl2.1)))
Please double-check whether it’s really explicitly “v2.1-only”. By
default, it’s “or any later version”, meaning ‘lgpl2.1+’.
Thanks,
Ludo’.
next prev parent reply other threads:[~2024-09-30 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 21:15 [bug#73260] Add libguestfs paul via Guix-patches via
2024-09-14 21:20 ` [bug#73260] [PATCH 1/3] gnu: Add hivex Giacomo Leidi via Guix-patches via
2024-09-14 21:20 ` [bug#73260] [PATCH 2/3] gnu: Add libguestfs-minimal Giacomo Leidi via Guix-patches via
2024-09-30 17:07 ` [bug#73260] Add libguestfs Ludovic Courtès
2024-09-14 21:20 ` [bug#73260] [PATCH 3/3] gnu: " Giacomo Leidi via Guix-patches via
2024-09-30 17:08 ` [bug#73260] " Ludovic Courtès
2024-10-04 22:31 ` paul via Guix-patches via
2024-09-30 17:03 ` Ludovic Courtès [this message]
2024-09-16 12:15 ` [bug#73260] Jiri Spacek via Guix-patches
2024-10-04 22:31 ` [bug#73260] [PATCH v2 1/3] gnu: Add hivex Giacomo Leidi via Guix-patches via
2024-10-04 22:31 ` [bug#73260] [PATCH v2 2/3] gnu: Add libguestfs-minimal Giacomo Leidi via Guix-patches via
2024-10-04 22:31 ` [bug#73260] [PATCH v2 3/3] gnu: Add libguestfs Giacomo Leidi via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfnp5b0g.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=73260@debbugs.gnu.org \
--cc=goodoldpaul@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).