From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gPMmBo7/DWfJcwAAe85BDQ:P1 (envelope-from ) for ; Tue, 15 Oct 2024 05:37:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id gPMmBo7/DWfJcwAAe85BDQ (envelope-from ) for ; Tue, 15 Oct 2024 07:37:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=nYoveLgF; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728970638; a=rsa-sha256; cv=none; b=ED/VhtoSl2iIpQaQ5nxuWHO5vjgNI3Xtvn091kw25j6l7ynMvW9Wlk+CRPQAkkeb8QF41J kmNFAIaBdYcHQBwbwIPGlKWzLo+0kgqycLcy5yVkWbd5dJTak8bLS2yQDo3WPh8GWVp9Q8 molrpjRpGu4M/gd95Kg76cJVQikcHmQnDUvbni7dFIny8QBTJt1bzCUR6w0NEAtLjV70WG rIII4i4wRUxXSgAgWGku+bFakWD2Ryf7rYHzn2SxLXCzHd8j5NIz/LASwvmsQvpbXwUQkE 4vWhw0sY382nQtT7C9Hes2pOfDOJWhWljG0Ec0F8Y36MiBGCkmBiRBTrdChk4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=nYoveLgF; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728970638; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Zg+uQfsGru81sdB7Nt7OJqbsHQppRXb6MYeXyFNMODA=; b=R1Ki0cCUvB/6edx+RMz28lHn2apBNRbQvbMKeALltkHiNsr2uo65LrZZDKJNZbGuw20zre kcZYUs02g+UKGMxuDk5PadT8phUPRfcDiHFuycAmbdHGRDqPBkZD+nfzLgZpUhLSdXyTey XMYCJ6nk1vNenhagiLNqpg7KOtqZV1KzHgf+cR4dtu4cTpqp9osY1mcLb9dP5Ut72pLuk7 x/+qx347YF64Klb3yOowUcK3cEK/J8Ygf8i0AQ7VcwhUQ0vnfuzWjHp4fQwsOyfO3BcUvg u0vzeGIC6zlJx2mn17YiUsp2mVDYKD3WLVcz6SCKGyVBYsZjOzi69g4/Dfe9SA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D4B1829C3 for ; Tue, 15 Oct 2024 07:37:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0aEi-0002fZ-Ne; Tue, 15 Oct 2024 01:36:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0aEe-0002en-W4 for guix-patches@gnu.org; Tue, 15 Oct 2024 01:36:45 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0aEe-0005jr-O6 for guix-patches@gnu.org; Tue, 15 Oct 2024 01:36:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Zg+uQfsGru81sdB7Nt7OJqbsHQppRXb6MYeXyFNMODA=; b=nYoveLgFdZXlFvJxkpnZzqcPspiAtST8Mj7V4G7/V3e7NCGUhAEGohnEIu9n618hd65baR+hDA9D4iX8e8hMRAQ9ANl9HmFAqGsQjouDFmDgngaWq4t6I3h/D6WpCqT/k5lrR81y6ODbB8vXgGk2EF9UNnwfHa7xTJ5L1Gw6HFEJtz/YBiVSeYZeSnaNVxaBBtIqbBOh4UFd1nxk5FbwFdHWJ8742gDg6B3QDrO0yUr5KimXAbD8jQ/P33QXz77dRf9IMrE/g1GO/J11ZcEpwSqwEmAgbtOKocEfF83tcYauKbB4Xh3+vvenu4r1rWZDQxCJLhEj8MApaknwcG7e3Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0aEw-000495-A0 for guix-patches@gnu.org; Tue, 15 Oct 2024 01:37:02 -0400 Subject: bug#73804: [PATCH] gnu: qqc2-desktop-style: Add kcolorscheme as an input. Resent-From: Zheng Junjie Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 15 Oct 2024 05:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: aurtzy Cc: 73804-done@debbugs.gnu.org Mail-Followup-To: 73804@debbugs.gnu.org, zhengjunjie@iscas.ac.cn, aurtzy@gmail.com Received: via spool by 73804-done@debbugs.gnu.org id=D73804.172897056915824 (code D ref 73804); Tue, 15 Oct 2024 05:37:01 +0000 Received: (at 73804-done) by debbugs.gnu.org; 15 Oct 2024 05:36:09 +0000 Received: from localhost ([127.0.0.1]:52473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0aE5-000479-2X for submit@debbugs.gnu.org; Tue, 15 Oct 2024 01:36:09 -0400 Received: from smtp84.cstnet.cn ([159.226.251.84]:35650 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0aE1-00046I-86 for 73804-done@debbugs.gnu.org; Tue, 15 Oct 2024 01:36:07 -0400 Received: from m (unknown [107.174.64.25]) by APP-05 (Coremail) with SMTP id zQCowAAnL_Mf_w1nVcecBw--.63987S2; Tue, 15 Oct 2024 13:35:34 +0800 (CST) From: Zheng Junjie In-Reply-To: <01818e2901e02eeb4aba79cfbb1031886a3fb6a7.1728927759.git.aurtzy@gmail.com> (aurtzy@gmail.com's message of "Mon, 14 Oct 2024 13:46:19 -0400") References: <01818e2901e02eeb4aba79cfbb1031886a3fb6a7.1728927759.git.aurtzy@gmail.com> Date: Tue, 15 Oct 2024 13:35:10 +0800 Message-ID: <87zfn63p4h.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-CM-TRANSID: zQCowAAnL_Mf_w1nVcecBw--.63987S2 X-Coremail-Antispam: 1UD129KBjvJXoWxZF45Kw15Cw18tFWfGryUJrb_yoW7Jr15pr s3tr1agFZ2kFWktwn2qa1v9F1Yqr98GF1UGw4DAr18t3s09FyUZFZIgF48XFW3JrZrZa43 uF4rKrW7W34vyrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvGb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwV C2z280aVCY1x0267AKxVWxJr0_GcWlnx0Ee4C267I2x7xF54xIwI0E7I0Y6sxI4wAS0I0E 0xvYzxvE52x082IY62kv0487M2AExVA0xI801c8C04v7Mc02F40EFcxC0VAKzVAqx4xG6I 80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCj c4AY6r1j6r4UM4x0Y48IcVAKI48JMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r 1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CE b7AF67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0x vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAI cVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa 73UjIFyTuYvjxU6cdbDUUUU X-Originating-IP: [107.174.64.25] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.76 X-Spam-Score: -3.76 X-Migadu-Queue-Id: 4D4B1829C3 X-Migadu-Scanner: mx12.migadu.com X-TUID: SHtMJ8s+iNfB --=-=-= Content-Type: text/plain aurtzy writes: > This remedies an issue where applications like systemsettings and > plasma-discover do not completely respect theming (e.g. when dark theme is > enabled), with the following notable error message: > > kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop" > > * gnu/packages/kde-frameworks.scm (qqc2-desktop-style)[inputs]: Add > kcolorscheme to fix a theming issue. > [arguments]<#:tests?>: Disable failing tests introduced by adding the > kcolorscheme input. > > Change-Id: Ic34da2a2fc788737e543eb3cd2b23edf85a736a4 > --- > > Hi! > > According to 'guix refresh --list-dependents qqc2-desktop-style', there > are 18 dependent packages. > > I haven't noticed any visible regressions with this change running > Plasma, and I can confirm theming in at least systemsettings and > plasma-discover is fixed by the change. However, adding kcolorscheme as > an input causes the check phase to fail (log included at the end). This > appears to be due to tests that are enabled when kcolorscheme is added, > one of which fails. > > The D-Bus error message is present in the current and patched > version. I've tried setting the HOME and XDG_CACHE_HOME environment > variables as it's done in other Qt/KDE packages, which has some effect > on the tests but still results in failure. The Nix packages seem to > reveal a partially circular dependency between qqc2-desktop-style and > kirigami [1] [2]; I wonder if this is related to the issue? > > Here's the check phase log: > > --8<---------------cut here---------------start------------->8--- > D-Bus library appears to be incorrectly set up: see the manual page for dbus-uuidgen to correct this issue. (Failed to open "/var/lib/dbus/machine-id": No such file or directory; Failed to open "/etc/machine-id": No such file or directory) > Test project /tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/build > Start 1: animationspeedmodifiertest > 1/2 Test #1: animationspeedmodifiertest .......***Failed 0.11 sec > ********* Start testing of IntegrationTest ********* > Config: Using QtTest library 6.6.3, Qt 6.6.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 11.4.0), unknown unknown > QWARN : IntegrationTest::initTestCase() kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop" > PASS : IntegrationTest::initTestCase() > QWARN : IntegrationTest::testAnimationSpeedModifier_kconfig() kf.config.core: Couldn't create a new file: "/homeless-shelter/.qttest/config/kdeglobals" . Error: "No such file or directory" > FAIL! : IntegrationTest::testAnimationSpeedModifier_kconfig() 'kdeGroup.sync()' returned FALSE. () > Loc: [/tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/qqc2-desktop-style-6.5.0/kirigami-plasmadesktop-integration/autotests/animationspeedmodifiertest.cpp(69)] > PASS : IntegrationTest::cleanupTestCase() > Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 26ms > ********* Finished testing of IntegrationTest ********* > Fontconfig error: No writable cache directories > Fontconfig error: No writable cache directories > > Start 2: TextFieldContextMenuTest > 2/2 Test #2: TextFieldContextMenuTest ......... Passed 3.12 sec > > 50% tests passed, 1 tests failed out of 2 > > Total Test time (real) = 3.23 sec > > The following tests FAILED: > 1 - animationspeedmodifiertest (Failed) > --8<---------------cut here---------------end--------------->8--- > > [1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/kirigami/default.nix > > [2] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/qqc2-desktop-style/default.nix > > Cheers, > > aurtzy > > gnu/packages/kde-frameworks.scm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm > index 974fd1c4dd..e7c8eef775 100644 > --- a/gnu/packages/kde-frameworks.scm > +++ b/gnu/packages/kde-frameworks.scm > @@ -1971,6 +1971,7 @@ (define-public qqc2-desktop-style > (build-system qt-build-system) > (arguments > (list > + #:tests? #f ; FIXME: 1/2 tests fail. > #:qtbase qtbase > #:phases #~(modify-phases %standard-phases > (replace 'check > @@ -1982,6 +1983,7 @@ (define-public qqc2-desktop-style > (list extra-cmake-modules dbus pkg-config qttools)) > (inputs > (list kauth > + kcolorscheme > kconfig ; optional > kcoreaddons > kiconthemes ; optional > > base-commit: 5a77f79764ccc01eb545e55027d0147e64a81952 Thanks!. push. And i add a commit to fix tests, move check phase after install, and Set QML_IMPORT_PATH, QT_PLUGIN_PATH,HOME environment variables. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmcN/w4ACgkQO1qpk+Gi 3/BoHRAAnpyHxYpEXV2bH3xhjfm7t3cpez3CcercMl1uBtUGDkI+54ibTpxeye0a HnrpggnQ+FaEgkLP2h5/FVkRS/kwC7UcHoe6ZYX8i3slo9Fbwf74tps16a4hQgRb v2NBj/2d78g1ce5/uFACBsGc4GUiAy+4VTiD/Yu3C1mpZrTdhaZJRCj8HQk7Vqdb Km63U9VegCmtEMIrL/pqncBENkUkiSFow7LguFIUyIrtMO5ZQ9ExXS2PBkOHQy9N yKp85E/vVsbbl/ktEsVur4bYYlOIwR72+xRgnMRTZFi7pKGTQox4OFt+8Iv0o6Ip aO7iR/ki29cfB8YJv0JOpYhSVlJHHZvPpFBAEAPaqMWvyEAzp5ZfQuQfvGD32Bjy qf9+OkgO+vEhosPWATzOdF/sZfTgdfi+WU5BtUcRN+5C2yigiMUZ2fMwC/fUG4w3 66Cxpxfdk0odUH065cevfjaMXGYgwAdkoADjPo7Eq2+6bA8X/4bTy4Q3fJOxdUDC wAbcBDMCE7LhJKJLpVmb7/4EFkiYZkBBn7QLvGOhbrTHPi+XTQ76cpeCf4SU+jji Y+gtC0XdttnSy3MvOKFi7MZcgQTz0G2aC4wrElmCK/3u9HIjQCTARnKkh69rmVoR tU58h5xC4g3g2tC1NcgHuKpU7ec2ZvXFvLfM2NYmCStL+ioPn7I= =LTd/ -----END PGP SIGNATURE----- --=-=-=--