From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
To: aurtzy <aurtzy@gmail.com>
Cc: 73804-done@debbugs.gnu.org
Subject: bug#73804: [PATCH] gnu: qqc2-desktop-style: Add kcolorscheme as an input.
Date: Tue, 15 Oct 2024 13:35:10 +0800 [thread overview]
Message-ID: <87zfn63p4h.fsf@iscas.ac.cn> (raw)
In-Reply-To: <01818e2901e02eeb4aba79cfbb1031886a3fb6a7.1728927759.git.aurtzy@gmail.com> (aurtzy@gmail.com's message of "Mon, 14 Oct 2024 13:46:19 -0400")
[-- Attachment #1: Type: text/plain, Size: 4745 bytes --]
aurtzy <aurtzy@gmail.com> writes:
> This remedies an issue where applications like systemsettings and
> plasma-discover do not completely respect theming (e.g. when dark theme is
> enabled), with the following notable error message:
>
> kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop"
>
> * gnu/packages/kde-frameworks.scm (qqc2-desktop-style)[inputs]: Add
> kcolorscheme to fix a theming issue.
> [arguments]<#:tests?>: Disable failing tests introduced by adding the
> kcolorscheme input.
>
> Change-Id: Ic34da2a2fc788737e543eb3cd2b23edf85a736a4
> ---
>
> Hi!
>
> According to 'guix refresh --list-dependents qqc2-desktop-style', there
> are 18 dependent packages.
>
> I haven't noticed any visible regressions with this change running
> Plasma, and I can confirm theming in at least systemsettings and
> plasma-discover is fixed by the change. However, adding kcolorscheme as
> an input causes the check phase to fail (log included at the end). This
> appears to be due to tests that are enabled when kcolorscheme is added,
> one of which fails.
>
> The D-Bus error message is present in the current and patched
> version. I've tried setting the HOME and XDG_CACHE_HOME environment
> variables as it's done in other Qt/KDE packages, which has some effect
> on the tests but still results in failure. The Nix packages seem to
> reveal a partially circular dependency between qqc2-desktop-style and
> kirigami [1] [2]; I wonder if this is related to the issue?
>
> Here's the check phase log:
>
> --8<---------------cut here---------------start------------->8---
> D-Bus library appears to be incorrectly set up: see the manual page for dbus-uuidgen to correct this issue. (Failed to open "/var/lib/dbus/machine-id": No such file or directory; Failed to open "/etc/machine-id": No such file or directory)
> Test project /tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/build
> Start 1: animationspeedmodifiertest
> 1/2 Test #1: animationspeedmodifiertest .......***Failed 0.11 sec
> ********* Start testing of IntegrationTest *********
> Config: Using QtTest library 6.6.3, Qt 6.6.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 11.4.0), unknown unknown
> QWARN : IntegrationTest::initTestCase() kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop"
> PASS : IntegrationTest::initTestCase()
> QWARN : IntegrationTest::testAnimationSpeedModifier_kconfig() kf.config.core: Couldn't create a new file: "/homeless-shelter/.qttest/config/kdeglobals" . Error: "No such file or directory"
> FAIL! : IntegrationTest::testAnimationSpeedModifier_kconfig() 'kdeGroup.sync()' returned FALSE. ()
> Loc: [/tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/qqc2-desktop-style-6.5.0/kirigami-plasmadesktop-integration/autotests/animationspeedmodifiertest.cpp(69)]
> PASS : IntegrationTest::cleanupTestCase()
> Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 26ms
> ********* Finished testing of IntegrationTest *********
> Fontconfig error: No writable cache directories
> Fontconfig error: No writable cache directories
>
> Start 2: TextFieldContextMenuTest
> 2/2 Test #2: TextFieldContextMenuTest ......... Passed 3.12 sec
>
> 50% tests passed, 1 tests failed out of 2
>
> Total Test time (real) = 3.23 sec
>
> The following tests FAILED:
> 1 - animationspeedmodifiertest (Failed)
> --8<---------------cut here---------------end--------------->8---
>
> [1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/kirigami/default.nix
>
> [2] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/qqc2-desktop-style/default.nix
>
> Cheers,
>
> aurtzy
>
> gnu/packages/kde-frameworks.scm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 974fd1c4dd..e7c8eef775 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -1971,6 +1971,7 @@ (define-public qqc2-desktop-style
> (build-system qt-build-system)
> (arguments
> (list
> + #:tests? #f ; FIXME: 1/2 tests fail.
> #:qtbase qtbase
> #:phases #~(modify-phases %standard-phases
> (replace 'check
> @@ -1982,6 +1983,7 @@ (define-public qqc2-desktop-style
> (list extra-cmake-modules dbus pkg-config qttools))
> (inputs
> (list kauth
> + kcolorscheme
> kconfig ; optional
> kcoreaddons
> kiconthemes ; optional
>
> base-commit: 5a77f79764ccc01eb545e55027d0147e64a81952
Thanks!. push. And i add a commit to fix tests, move check phase after install,
and Set QML_IMPORT_PATH, QT_PLUGIN_PATH,HOME environment variables.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2024-10-15 5:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 17:46 [bug#73804] [PATCH] gnu: qqc2-desktop-style: Add kcolorscheme as an input aurtzy
2024-10-15 5:35 ` Zheng Junjie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfn63p4h.fsf@iscas.ac.cn \
--to=zhengjunjie@iscas.ac.cn \
--cc=73804-done@debbugs.gnu.org \
--cc=aurtzy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).