unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: Rostislav Svoboda <rostislav.svoboda@gmail.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>,
	74137@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>
Subject: [bug#74137] [PATCH] gnu: Add emacs-vi-tilde-fringe.
Date: Fri, 01 Nov 2024 23:21:34 +0100	[thread overview]
Message-ID: <87zfmik32p.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAEtmmexz6ic5S24jjsjGd4S14bqdoMm-RKf3QXfJobSSFLURrw@mail.gmail.com> (Rostislav Svoboda's message of "Fri, 1 Nov 2024 21:23:30 +0100")

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

>> We use revision and commits to distinguish versions from plain ones, to
>> say : "be careful, we didn't package the exact 1.0 release".
>
> This is information no one can reliably depend on, as there's no
> mechanism to guarantee what you're suggesting.
>
>> I'm advocating for removing that information from the version field only.
>> We're already doing this for projects that do not tag releases. See, e.g.,
>> `emacs-inspector'.
>
> If you want to be *sure* that emacs-inspector includes no
> (modify-phases ...), you'll need to check its definition anyway.
> There's no point in hiding the commit hash.
>
> On the contrary, the commit hash is quite useful. It immediately and
> reliably indicates which commit was used to build a package.
>
> This information is particularly helpful when performing a git bisect,
> manually inspecting the /gnu/store, and similar tasks.

AFAICT, this is not what is done in Guix. Usually versions follow
upstream tags, and revisions+commits are the exception, not the rule.

You seem to have a divergent opinion on the subject. That's fair, but
I think we're at a dead end now. Since I don't want to block nor delay
this patch, I'll let others proceed with the review.

Regards,






      reply	other threads:[~2024-11-01 22:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 13:59 [bug#74137] [PATCH] gnu: Add emacs-vi-tilde-fringe Rostislav Svoboda
2024-11-01 14:31 ` Nicolas Goaziou via Guix-patches via
2024-11-01 14:41   ` Rostislav Svoboda
2024-11-01 15:02     ` Nicolas Goaziou via Guix-patches via
2024-11-01 15:51       ` Rostislav Svoboda
2024-11-01 16:05         ` Nicolas Goaziou via Guix-patches via
2024-11-01 20:23           ` Rostislav Svoboda
2024-11-01 22:21             ` Nicolas Goaziou via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfmik32p.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=74137@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    --cc=rostislav.svoboda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).