From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CL31K/3MTGcaJAAAqHPOHw:P1 (envelope-from ) for ; Sun, 01 Dec 2024 20:54:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id CL31K/3MTGcaJAAAqHPOHw (envelope-from ) for ; Sun, 01 Dec 2024 21:54:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Bw7jddKH; dkim=fail ("headers rsa verify failed") header.d=whispers-vpn.org header.s=protonmail header.b=AfgRuUdy; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733086461; a=rsa-sha256; cv=none; b=Ri9dbaBB4Djr+c1X8OBs68yi5+fazscxWZUpLBIWjZuXeukFQYSkpUNl3ODfViu0m3wGF7 2VzIVmFTOh8yK7v5WobF5oEBh7xmwe0rpWgAqnR4eTfb2tM7CUfVNA7Uc6YEdTJJf6qIXs lwMSO5T2jVgWBg3kTY6r/CKduavjzlXRPvF76cYTsVwwn/fYY1Wz26MIYRH5J5Cpb7S/i7 ZYOnwt2vQUjh6uNZz3vwdQjn/7Ub8FibCOHC17F41GTbs72lvuWMOT5lo8ysSjblOHv9mL cHXKqd5FhjCorWNnU6gd5x8bescAscA4ooUux2Si8b4qhE3wVX/Xrl2mxtPk+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Bw7jddKH; dkim=fail ("headers rsa verify failed") header.d=whispers-vpn.org header.s=protonmail header.b=AfgRuUdy; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733086461; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IE8Cw7PblcKpuxPsog6fj+JY6uhEm0iKZD9jRwm+k0E=; b=WK7UigZFyOtu5kGCCOPzscmkcQbsTY8brxTZc/8VsZPcAE2rUSkdCsyIxfkWXxwhFL2yDs imaKB/19f4qGK1okXDOrwthRjkJUEL81Obq2J7Fzfbjz4MzFG+jyFayIMYNTUe/+2GqQ3B TGVPacYXmpFEcQuBNfwP4Kpki1hIxOYynn7i5sfMyaGtUOTRkpzgTjy6wNOlGzRdWAkx7j YPgDGwAhrNgOYsoEMYYuUJVGbosnrkr0jRG77NfXN6tRRsQeEpgGLnAnDUQsOj/2EU9A42 Ph38mnebcHA+WpHRkl8qYy5TMVE6SryLkpZW7qoHAL6G+H+M+/z2lThvCjV6mg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87B291D4A0 for ; Sun, 01 Dec 2024 21:54:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHqxA-00083O-Ge; Sun, 01 Dec 2024 15:54:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHqx8-00083B-UH for guix-patches@gnu.org; Sun, 01 Dec 2024 15:54:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHqx8-0003kU-Ll for guix-patches@gnu.org; Sun, 01 Dec 2024 15:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:In-Reply-To:References:Subject; bh=IE8Cw7PblcKpuxPsog6fj+JY6uhEm0iKZD9jRwm+k0E=; b=Bw7jddKHYLhLVwczCmYJYbE6+sBQD0kXMdM6tuaqIf86Y13srGb85KbYyZjV+UaWzY9RaRG9g5aSS3v/C7q57jYXsMXp2emcUHZr++jOilekhX0+Iq5xiJSWyou5f6F7iaSkNZjozoDOWxcfgIm4lFbga9lmmHofPf1F8MPXQD+lQJRLlF272GggRCFdXKUwyWEg4Jhq8KAAvVyledFHGrPLpR2V2Bt3YKozgHVjnU6lABTAWAVCBkPIa8Kf47pcPmdIo8luku66hjKiapP4tp7xMkRLKZVo2FbX6SEy1F9m4yS/5okmnzPMdDRUC5ZQ0jIklk4Ul1fUWH5IjycjtA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHqx8-000804-GL for guix-patches@gnu.org; Sun, 01 Dec 2024 15:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74411] [PATCH v2 4/5] gnu: Add freedict-dictionaries. References: In-Reply-To: Resent-From: Runciter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 01 Dec 2024 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74411 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 74411@debbugs.gnu.org Received: via spool by 74411-submit@debbugs.gnu.org id=B74411.173308640730697 (code B ref 74411); Sun, 01 Dec 2024 20:54:02 +0000 Received: (at 74411) by debbugs.gnu.org; 1 Dec 2024 20:53:27 +0000 Received: from localhost ([127.0.0.1]:53238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHqwY-0007z3-WB for submit@debbugs.gnu.org; Sun, 01 Dec 2024 15:53:27 -0500 Received: from mail-40136.proton.ch ([185.70.40.136]:59603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHqwX-0007yo-2H for 74411@debbugs.gnu.org; Sun, 01 Dec 2024 15:53:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whispers-vpn.org; s=protonmail; t=1733086398; x=1733345598; bh=IE8Cw7PblcKpuxPsog6fj+JY6uhEm0iKZD9jRwm+k0E=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=AfgRuUdy0OodrpDH9vhyaWMGkbX0HogZE6/iPaVIW4aUL8KeLq0TO2W8S0RlRIprr wqXQXsXXK0jindtWphr2hzkw+MaL3a1+RyWEL45AfvV2RP8GbKln2rwReXEJl2ppis +QQVpLqiQ+adPHqfFMgYpT+yirsqWS81dU6HC6bLy9BaH+OgTd6iQ8uxtaHVDhFbo4 inxgW/DKN/40tg8OrRDZRYYc40/F5B7/1XwD6iL+F08Lw/RCAWqUvNldMcGNfYoRCO Pm+K5BNk5E/ygxf+t8HhY0DuaZzb4ZbpAZg4jWlTjK/c5x845nOO1QCKYA8/qESf3v a0kdan5EcOeag== Date: Sun, 01 Dec 2024 20:53:15 +0000 Message-ID: <87zflfw2fd.fsf@whispers-vpn.org> Feedback-ID: 119317227:user:proton X-Pm-Message-ID: 00b57426e7a214d317bb540be9d7a5a018521e5c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Runciter X-ACL-Warn: , Runciter via Guix-patches From: Runciter via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.65 X-Spam-Score: -2.65 X-Migadu-Queue-Id: 87B291D4A0 X-Migadu-Scanner: mx12.migadu.com X-TUID: z85GAl61FGFA Ludovic Court=C3=A8s writes: >> +(define-public freedict-dictionaries >> + (package >> + (name "freedict-dictionaries") >> + (version "914b5f7") > > Regarding the version number of Git snapshots, see > . I don't find anything that looks like an overall upstream version for the whole freedict-dictionaries package. It seems only individual dictionaries are (partially?) versioned. Therefore at this time I don't have a unique and correct argument I could feed to git-version. >> + (arguments >> + (list >> + #:tests? #f > > Please add a short comment explaining why the test suite is skipped > (such as =E2=80=9Cno tests=E2=80=9D). Actually There is a "validation" target that could be considered for the test phase. It lints a xml source file for each dictionary. However it fails because of a hard-coded "/usr/bin/xmllint" path in freedict-tools. I added a comment to mention this issue. This might be fixable; I'll try if requested by a maintainer. I have not tried yet because it would probably require an extra special measure, in the form of either a patch or regexp substitution. Regards, Runciter