unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Marco Fortina" <marco_fortina@hotmail.it>,
	"Ludovic Courtès" <ludo@gnu.org>
Cc: "guix-patches@gnu.org" <guix-patches@gnu.org>,
	 "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [bug#62917] [bug#73799] [PATCH] Fix 'guix shell: error: symlink: File exists: "/bin/cc"'
Date: Sun, 15 Dec 2024 13:36:01 +0900	[thread overview]
Message-ID: <87zfkxy34e.fsf@gmail.com> (raw)
In-Reply-To: <AS8PR10MB58291EBFC600E5EDCCB20C39F74C2@AS8PR10MB5829.EURPRD10.PROD.OUTLOOK.COM> (Marco Fortina's message of "Tue, 22 Oct 2024 10:49:32 +0000")

Hi Marco,

Marco Fortina <marco_fortina@hotmail.it> writes:

> This patch closes issue when running "guix shell --container --emulate-fhs clang-toolchain gcc-toolchain" or "guix shell --container --emulate-fhs clang-toolchain gcc-toolchain":
>
>
> diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
> index a219b2ac89..37f11395f9 100644
> --- a/guix/scripts/environment.scm
> +++ b/guix/scripts/environment.scm
> @@ -464,7 +464,8 @@ (define (setup-fhs profile)
>    ;; /bin since that already has the sh symlink and the other (optional) FHS
>    ;; bin directories will link to /bin.
>    (let ((gcc-path (string-append profile "/bin/gcc")))
> -    (if (file-exists? gcc-path)
> +    (if (and (file-exists? gcc-path)
> +             (not (file-exists? "/bin/cc")))
>          (symlink gcc-path "/bin/cc")))
>
>    ;; Guix's ldconfig doesn't search in FHS default locations, so provide a

I see Ludovic pushed a variant of the above fix with
23ab6fc29f28b0fa9ad94bf2ceed135ee3fdea34, and attributed your discovery
of the problem.

Good.  Thanks for the report and patch!

-- 
Thanks,
Maxim


      parent reply	other threads:[~2024-12-15  4:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2085439243.1521663.1681776855547@privateemail.com>
2024-10-22 10:49 ` [bug#62917] [bug#73799] [PATCH] Fix 'guix shell: error: symlink: File exists: "/bin/cc"' Marco Fortina
2024-10-22 10:49   ` bug#62917: " Marco Fortina
2024-12-15  4:36   ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfkxy34e.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=guix-patches@gnu.org \
    --cc=ludo@gnu.org \
    --cc=marco_fortina@hotmail.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).