unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Andy Wingo <wingo@igalia.com>
Cc: 26687@debbugs.gnu.org
Subject: bug#26687: add git http support service
Date: Wed, 03 May 2017 14:11:39 +0200	[thread overview]
Message-ID: <87y3ueta10.fsf@gnu.org> (raw)
In-Reply-To: <cucefwdehbp.fsf@igalia.com> (Andy Wingo's message of "Thu, 27 Apr 2017 22:17:14 +0200")

Andy Wingo <wingo@igalia.com> skribis:

> Attached pair of patches adds git http "support" to the manual.  I say
> "support" because really what you usually want to do is extend an
> existing nginx server with git support, not make an entirely new
> server.  But right now we can't extend servers, so this support is a bit
> preliminary.  Still, it's better than ad hoc logic in peoples'
> configuration files.

Agreed, that’s a nice addition.

>>From 80d872ae8362b5e769c463599b03ddb0fb7482d2 Mon Sep 17 00:00:00 2001
> From: Andy Wingo <wingo@igalia.com>
> Date: Thu, 27 Apr 2017 10:59:44 +0200
> Subject: [PATCH 4/5] doc: Create Version Control Services section.
>
> * doc/guix.texi (Version Control Services): Move to its own node.

OK.

>>From cb9f33e2a70b304cc5712d8a369dc8db7a8ae95b Mon Sep 17 00:00:00 2001
> From: Andy Wingo <wingo@igalia.com>
> Date: Thu, 27 Apr 2017 15:02:19 +0200
> Subject: [PATCH 5/5] gnu: Add Git HTTP(S) service support.
>
> * doc/guix.texi (Version Control Services): Add documentation on the HTTP
> backend for git.
> * gnu/services/version-control.scm (<git-http-configuration>): New data type.
> (git-http-nginx-location-configuration): New helper function.

[...]

> +The @code{git://} protocol lacks authentication.  When you pull from a
> +repository fetched via @code{git://}, you don't know that the data you
> +receive was modified in transit or not.  It's better to use an

Nitpick: “modified in transit” refers to integrity, not authenticity;
perhaps write “you don’t know that the data you receive is really coming
from the specified host”?

Also maybe “lacks authentication and confidentiality”.

> +(define* (git-http-nginx-location-configuration #:optional
> +                                                (config
> +                                                 (git-http-configuration)))

Perhaps “git-http-configuration->nginx-location”?

OK with changes along these lines!

Eventually we should consider adding tests for the Git services.

Thank you,
Ludo’.

  reply	other threads:[~2017-05-03 12:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 20:17 bug#26687: add git http support service Andy Wingo
2017-05-03 12:11 ` Ludovic Courtès [this message]
2017-11-28 22:43   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3ueta10.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26687@debbugs.gnu.org \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).