unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Alex Kost <alezost@gmail.com>, 26860@debbugs.gnu.org
Subject: bug#26860: [PATCH] Remove hard dependency on guile-json
Date: Wed, 17 May 2017 10:33:23 +0200	[thread overview]
Message-ID: <87y3tvzxv0.fsf@gnu.org> (raw)
In-Reply-To: <87a86li5ci.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 10 May 2017 08:38:37 +0200")

Ricardo Wurmus <rekado@elephly.net> skribis:

> Alex Kost <alezost@gmail.com> writes:
>
>> Hello.  Currently, Guix cannot be built without guile-json.  The
>> attached patch fixes it.
>>
>>>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost@gmail.com>
>> Date: Tue, 9 May 2017 22:44:19 +0300
>> Subject: [PATCH] build: Compile stackage only if 'guile-json' is available.
>>
>> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642.
>>
>> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within
>> 'if HAVE_GUILE_JSON'.
>
> Would it not work to autoload the module?
> “guix/scripts/import/stackage.scm” itself does not require guile json.
>
> Something like that is done in commit
> fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer
> branch).

Ricardo, could you take a look at this?

I’m not sure if autoloading works, unless we use the ‘module-autoload!’
hack as done in other places.

TIA.  :-)

Ludo’.

  parent reply	other threads:[~2017-05-17  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09 19:53 bug#26860: [PATCH] Remove hard dependency on guile-json Alex Kost
2017-05-09 20:43 ` Danny Milosavljevic
2017-05-10  6:38 ` Ricardo Wurmus
2017-05-10 19:18   ` Alex Kost
2017-05-17  8:33   ` Ludovic Courtès [this message]
2017-05-17 13:29 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3tvzxv0.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26860@debbugs.gnu.org \
    --cc=alezost@gmail.com \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).