From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBUI5-00057T-Fb for guix-patches@gnu.org; Thu, 18 May 2017 18:53:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBUI2-0000vQ-Uw for guix-patches@gnu.org; Thu, 18 May 2017 18:53:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51384) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dBUI2-0000vK-RM for guix-patches@gnu.org; Thu, 18 May 2017 18:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dBUI2-00018i-Eh for guix-patches@gnu.org; Thu, 18 May 2017 18:53:02 -0400 Subject: bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87inkxanzj.fsf@gnu.org> References: <87r2zoygoi.fsf@gnu.org> <20170517110522.18106-1-mbakke@fastmail.com> <20170517110522.18106-3-mbakke@fastmail.com> <87ziebtbph.fsf@gnu.org> <877f1ecf00.fsf@fastmail.com> <87inkxanzj.fsf@gnu.org> Date: Fri, 19 May 2017 00:52:28 +0200 Message-ID: <87y3ttbwwj.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26815@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >> From b2236aa915bfb32e974546790a1e87ef1b268403 Mon Sep 17 00:00:00 2001 >> From: Marius Bakke >> Date: Thu, 18 May 2017 18:10:31 +0200 >> Subject: [PATCH] vm: Initialize-hard-disk now takes a grub-efi parameter. >> >> * gnu/build/vm.scm (initialize-hard-disk): Learn #:grub-efi. >> (install-efi): Use it. >> * gnu/system/vm.scm (qemu-image): Pass it. > > LGTM! I suppose you=E2=80=99d squash it with the initial patch? Indeed. Figured this was an easier review format, though. I'll push this series shortly, after some basic sanity checks. Thanks a lot for the great feedback! I'll work on a more Guixy way of creating the standalone GRUB image and also a system test for the next release ;-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkeJawACgkQoqBt8qM6 VPrTUwf9EXtIwbMLY/ar6DpTtlGuifhFz3vzCevIHWVe7yHhXm1EegXBW278SKhC mxOmNkjS6iZQUg9/CxdufOsFsEYo0ZOzpuTbY228/3Rd4U21eLrkMdy44gsOefcd eQmnS4O4VIF6XFmeoFibExn/llLJsJHO3Cbh7lMDCvNYnB4VIkSAH5d7AaLN4hVh qpAFX4JLwUgxEMvDk2osfSi/ab+JGVU3bc/8d11OjkStzuf++zQ4g8EXtBeVIiRn svJrl7BNaxxDQ00m7rWF0lrUZaRpCVye6Rcs53CMpf25msUi+pFGV1EvayyRNHou C/5lBgfPbtnKzrAtLdIpL0TrtfoffA== =bWkL -----END PGP SIGNATURE----- --=-=-=--