[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Alex Vong <alexvong1995@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Arun Isaac <arunisaac@systemreboot.net> writes:

> Thanks for the patch!
>
>> +    (inputs `(("pkg-config" ,pkg-config)
>
> pkg-config should be a native input.
>
I forget to run lint before submitting the patch... I have fixed this
issue and other formatting issues reported by lint.

>> + ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability issues
>> +              ("ffmpeg" ,ffmpeg)
>> +              ("alsa-lib" ,alsa-lib)
>> +              ("pulseaudio" ,pulseaudio)
>> +              ("jack" ,jack-1)
>> +              ("glu" ,glu)
>> +              ("libx11" ,libx11)
>> +              ("libxfixes" ,libxfixes)
>> +              ("libxext" ,libxext)
>
> The package builds successfully without libx11, libxfixes and libxext
> included as inputs. Are you sure they are needed? Could you check again?
>
>> +              ("libxi" ,libxi)))
>
These packages are listed as Build dependencies in README[0]. What do
you think?

> Also, could you sort all the inputs in alphabetical order, just for the
> aesthetic appeal? :-)
>
>> +    ;; Using HTTPS causes part of the page displayed improperly.
>> +    (home-page "http://www.maartenbaert.be/simplescreenrecorder/")
>
> We'll go with the HTTP URL for now. But, do report this issue upstream
> as well.

Yeah, I'll report it later.

Thanks for the review!

[0]: https://github.com/MaartenBaert/ssr

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]