From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGhuz-000898-D3 for guix-patches@gnu.org; Mon, 20 Nov 2017 03:59:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGhuw-00053M-BP for guix-patches@gnu.org; Mon, 20 Nov 2017 03:59:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:39576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGhuw-000537-1j for guix-patches@gnu.org; Mon, 20 Nov 2017 03:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGhuv-0005Od-Kj for guix-patches@gnu.org; Mon, 20 Nov 2017 03:59:01 -0500 Subject: [bug#29359] [PATCH 22/31] gnu: Add java-dom4j. Resent-Message-ID: References: <20171119175805.902-1-julien@lepiller.eu> <20171119175805.902-22-julien@lepiller.eu> From: Ricardo Wurmus In-reply-to: <20171119175805.902-22-julien@lepiller.eu> Date: Mon, 20 Nov 2017 09:58:19 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87y3n1wclw.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 29359@debbugs.gnu.org Julien Lepiller writes: > * gnu/packages/java.scm (java-dom4j): New variable. Better: (gnu packages xml). [=E2=80=A6] > + (arguments > + `(#:jar-name "dom4j.jar" > + #:jdk ,icedtea-8 > + #:source-dir "src/main/java" > + #:tests? #f; Requires xalan, but xalan -> java-cup -> jflex -> ja= va-cup... So java-cup has a dependency on itself via jflex? Please add FIXME here, so that we can fix this once xalan is packaged. > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'copy-jaxen-sources > + ;; jaxen-no-rec-deps is not enough. These files have a circul= ar > + ;; dependency and there is no subset of dom4j that would allo= w > + ;; breaking the circle. I still don=E2=80=99t know where =E2=80=9Cjaxen-no-rec-deps=E2=80=9D comes = from. > + (add-before 'build 'fix-old-xpp2 > + (lambda _ > + ;; This package normally depends on xpp2 2.0, but we can on= ly package > + ;; version 2.1.10. Why? > + (substitute* "src/main/java/org/dom4j/xpp/ProxyXmlStartTag.= java" > + (("public void resetStartTag") > + (string-append > + "public boolean removeAttributeByRawName(String name) = {\n" > + " return false;\n" > + "}\n" > + "public boolean removeAttributeByName(String name, Str= ing name2) {\n" > + " return false;\n" > + "}\n" > + "\n" I prefer not to use string-append here. You can split strings and let them span multiple lines by escaping the line break. > + (inputs > + `(("java-jaxen-no-rec-deps" ,java-jaxen-no-rec-deps) > + ("java-jaxen-sources" ,(package-source > java-jaxen-no-rec-deps)) Please remember to rename this when renaming =E2=80=9Cjava-jaxen-no-rec-dep= s=E2=80=9D to =E2=80=9Cjava-jaxen-bootstrap=E2=80=9D. > + (home-page "https://dom4j.github.io/") > + (synopsis "Flexible XML framework for Java") > + (description "Dom4j is a flexible XML framework for Java.") That=E2=80=99s a bit short. Could you elaborate? > + ;; some BSD-like 5-clause license > + (license (license:non-copyleft "file://LICENSE")))) Weird license :) -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net