From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50096)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eNEr8-0005CT-46
	for guix-patches@gnu.org; Fri, 08 Dec 2017 04:22:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eNEr4-0004Lz-4M
	for guix-patches@gnu.org; Fri, 08 Dec 2017 04:22:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42630)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eNEr4-0004Lp-1I
	for guix-patches@gnu.org; Fri, 08 Dec 2017 04:22:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eNEr3-0007tf-PX
	for guix-patches@gnu.org; Fri, 08 Dec 2017 04:22:01 -0500
Subject: [bug#29517] [PATCH] gnu: gl: Add virtualgl. (v2)
Resent-Message-ID: <handler.29517.B29517.151272490830336@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <1475847efd9aa8a0f02d0f30f2539d48@mykolab.com>
	<6d6f1fcc7d9de399cb66f03747377f9b@mykolab.com>
Date: Fri, 08 Dec 2017 10:21:43 +0100
In-Reply-To: <6d6f1fcc7d9de399cb66f03747377f9b@mykolab.com> (Rutger Helling's
	message of "Thu, 07 Dec 2017 09:14:58 +0100")
Message-ID: <87y3md3788.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Rutger Helling <rhelling@mykolab.com>
Cc: 29517@debbugs.gnu.org

Hi,

Rutger Helling <rhelling@mykolab.com> skribis:

> From d2b7f7243a8831542538bad5bab14fba0693a4fc Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Thu, 7 Dec 2017 09:11:08 +0100
> Subject: [PATCH] gnu: gl: Add virtualgl.
>
> * gnu/packages/gl.scm (virtualgl): New variable.

LGTM, with a few minor issues:

> +    (home-page "https://www.virtualgl.org")
> +    (synopsis "Redirects 3D commands from an OpenGL application onto a 3D
> +graphics card")
> +    (description "VirtualGL is a free software program that redirects th=
e 3D

s/free software//

(Everything=E2=80=99s free software in Guix.  :-))

> +rendering commands from Unix and Linux OpenGL applications to 3D acceler=
ator

s/Unix and Linux//g

> +hardware in a dedicated server and displays the rendered output interact=
ively to
> +a thin client located elsewhere on the network.")
> +    (license license:lgpl2.1)))

Source code headers read this:

 * This library is free software and may be redistributed and/or modified u=
nder
 * the terms of the wxWindows Library License, Version 3.1 or (at your opti=
on)
 * any later version.  The full license is in the LICENSE.txt file included
 * with this distribution.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * wxWindows Library License for more details.

We don=E2=80=99t have that license in (guix licenses) yet.  Could you add i=
t and
send updated patches?

Thanks,
Ludo=E2=80=99.