From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee4TL-00021o-3D for guix-patches@gnu.org; Tue, 23 Jan 2018 14:43:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee4TG-0002rN-6X for guix-patches@gnu.org; Tue, 23 Jan 2018 14:43:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee4TG-0002rB-3I for guix-patches@gnu.org; Tue, 23 Jan 2018 14:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee4TF-0006qc-Tf for guix-patches@gnu.org; Tue, 23 Jan 2018 14:43:01 -0500 Subject: [bug#30214] [PATCH 01/10] gnu: Add go-golang.org-x-crypto-ssh-terminal. Resent-Message-ID: References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122215213.GB15170@jasmine.lan> From: Christopher Baines In-reply-to: <20180122215213.GB15170@jasmine.lan> Date: Tue, 23 Jan 2018 19:42:06 +0000 Message-ID: <87y3ko5pm9.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 30214@debbugs.gnu.org --=-=-= Content-Type: text/plain Leo Famulari writes: > On Mon, Jan 22, 2018 at 09:08:21PM +0000, Christopher Baines wrote: >> * gnu/packages/terminals.scm (go-golang.org-x-crypto-ssh-terminal): New >> variable. > >> +(define-public go-golang.org-x-crypto-ssh-terminal >> + (let ((commit "c78caca803c95773f48a844d3dcab04b9bc4d6dd") >> + (revision "0")) >> + (package >> + (name "go-golang.org-x-crypto-ssh-terminal") >> + (version (string-append "0.0.0-" revision "." (string-take commit 7))) > > Can you use (git-version "0.0.0" revision commit) here? > >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://go.googlesource.com/crypto") >> + (commit commit))) >> + (file-name (string-append "go.googlesource.com-crypto-" >> + version "-checkout")) > > And here, (git-file-name name version)? Sure, those sound like useful helpers. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpnkA5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcfRBAAnKWY3t70tzTDxPqAQ/01WMQ/SULgsc1BOo33lpWCOOMve8vcKesXxyva nPHlB6hqzN/0GvH5ZWEVAXrEQzbSumMFFTFCVB93wrfwstVxGwgwQFDs91oqapva VXAKcgfir2jQ34YMHqyskW44TSpciAsbejFEr0eiZGezOCg5VLjZZVE/pzM+tblB shSMRrddJwLHDeSJpnl4dK/uzA6mRgjTjDWbZp7JljEVmKUgRb3NUOHt0cPbipNS +ptgOk0fd85c/5aaANfqyptvccAhKyePciOWSRcoiroiExsyS0YTs6MxmEGgIyzs Bv6Ym3mxEegs8bbD4f3i0vyqqWBDt+sei2jw+yCvPjwuEfepingfdgDy2aD/uEqE NmjbTJz7NmdvEvtKLtjkuhXkCFt0UbpbhOtZg2oq7Td+pMZwBr+6H7V3eO89YdyQ avBQX4XrYpT9e6yObC02Elzey6KLBMtLeY6GGn8tj9PlDiRk9fYDSnEYwXD1ct4E 6/P2VBRm7/Zk29B4KBa57bpDeNQ46baCdf4ejzgjRXkccp3XWYpL9zS6BUyuQL4u D3uu/XHGtLYV5/6sbtB2n4kMsFQkPeAXyBsnWE2X9lju9nVYGfbVQj2NgPb8kcA1 s8E7y2Rtp9sEF5o+2J1OnnkPQoEgdGrMRbCaYudLHAiBMBINII8= =N9v8 -----END PGP SIGNATURE----- --=-=-=--