Hello Marius, apologies for a long reply. I fix a comment and have a question about clojure. Also a new patch is attached. Marius Bakke writes: > Oleg Pykhalov writes: > >> From 2eff4caca543d9909758a4f2eb6f953467a309d7 Mon Sep 17 00:00:00 2001 >> From: Oleg Pykhalov >> Date: Fri, 8 Dec 2017 18:51:10 +0300 >> Subject: [PATCH] gnu: qemu: Add pulseaudio support. >> >> * gnu/packages/virtualization.scm (qemu): Add pulseaudio support. > > Please mention the change to [inputs] and [arguments] here. OK. [...] >> #:phases >> (modify-phases %standard-phases >> (replace 'configure >> @@ -166,6 +171,7 @@ >> ("ncurses" ,ncurses) >> ;; ("pciutils" ,pciutils) >> ("pixman" ,pixman) >> + ("pulseaudio" ,pulseaudio) > > I see pulseaudio is already in Qemus closure, How do you see this? Is that what do you use? --8<---------------cut here---------------start------------->8--- guix graph --type=references pulseaudio | dot -Tsvg > pulseaudio.svg --8<---------------cut here---------------end--------------->8--- > so this does not add anything. LGTM! Hm, seems it doesn't. --8<---------------cut here---------------start------------->8--- starting phase `configure' ERROR: pa check failed Make sure to have the pa libs and headers installed. phase `configure' failed after 1.8 seconds builder for `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed with exit code 1 @ build-failed /gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv - 1 builder for `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed with exit code 1 guix build: error: build failed: build of `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed --8<---------------cut here---------------end--------------->8--- [...]