[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Hello Guix,
>
> Licensecheck attempts to determine the license that applies to each file
> passed to it, by searching the start of the file for text belonging to various
> licenses.

Nice!

I've read through the series, and the only remark I have is that it's
better to use 'perl-license' rather than (package-license perl) (see the
comment in (guix licenses)).  Probably won't be a problem any time soon,
but still.

Regarding the -2 variants, I assume other packages fail to build if they
are simply updated?  It would be good to have comments about it in the
code.

Apart from that LGTM, thank you!

> Oleg Pykhalov (21):
>   gnu: Add perl-test-filename.
>   gnu: Add perl-path-iterator-rule.
>   gnu: Add perl-pod-constants.
>   gnu: Add perl-regexp-pattern.
>   gnu: Add perl-regexp-pattern-license.
>   gnu: Add perl-number-range.
>   gnu: Add perl-string-copyright.
>   gnu: Add perl-string-escape.
>   gnu: Add perl-test-failwarnings.
>   gnu: Add perl-data-section.
>   gnu: Add perl-software-license.
>   gnu: Add perl-extutils-depends.
>   gnu: Add perl-b-hooks-op-check.
>   gnu: Add perl-bareword-filehandles.
>   gnu: Add perl-indirect.
>   gnu: Add perl-lexical-sealrequirehints.
>   gnu: Add perl-multidimensional.
>   gnu: Add perl-test-roo.
>   gnu: Add perl-universal-require.
>   gnu: Add perl-strictures-2.
>   gnu: Add licensecheck.
>
>  gnu/local.mk                |   1 +
>  gnu/packages/license.scm    | 158 ++++++++++++++++++++
>  gnu/packages/perl-check.scm |  73 ++++++++++
>  gnu/packages/perl.scm       | 340 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 572 insertions(+)
>  create mode 100644 gnu/packages/license.scm
>
> -- 
> 2.15.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]