From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42771)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1erL6F-0005TU-51
	for guix-patches@gnu.org; Thu, 01 Mar 2018 05:06:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1erL6A-0005Em-6i
	for guix-patches@gnu.org; Thu, 01 Mar 2018 05:06:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:58572)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1erL6A-0005Ef-3I
	for guix-patches@gnu.org; Thu, 01 Mar 2018 05:06:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1erL69-0007d9-Sm
	for guix-patches@gnu.org; Thu, 01 Mar 2018 05:06:01 -0500
Subject: [bug#30629] [PATCH 0/5] Detect missing modules in the initrd
Resent-Message-ID: <handler.30629.B30629.151989873829292@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180227141720.12513-1-ludo@gnu.org>
	<20180227222632.42bcf52c@scratchpost.org> <87tvu2w2vg.fsf@gnu.org>
	<20180227235027.00bc79b1@scratchpost.org>
Date: Thu, 01 Mar 2018 11:05:33 +0100
In-Reply-To: <20180227235027.00bc79b1@scratchpost.org> (Danny Milosavljevic's
	message of "Tue, 27 Feb 2018 23:50:27 +0100")
Message-ID: <87y3jc6rgy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 30629@debbugs.gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

>> > I'm not sure about the module resolution order, first use the aliases =
or first
>> > use the real module files?=20=20
>>=20
>> In what part?
>
> modprobe.  It can either get "pci:024215325233" or "ahci".  The first is =
an alias
> and the latter eventually resolves to a file "ahci.ko".

I see.  Does it make sense to first look up the name in modules.aliases,
and if that fails, assume it=E2=80=99s a module name?

>> > +                 (path (string-append linux-release-module-directory =
name)))=20=20
>>=20
>> s/path/directory/ :-)
>
> It's the full path to the module file (a regular file).  "name" was taken=
 :)

To avoid ambiguities, the GNU Coding Standards (and Guix) suggest using
the word =E2=80=9Cpath=E2=80=9D for search paths, and =E2=80=9Cfile name=E2=
=80=9D (or =E2=80=9Cfile=E2=80=9D, or
=E2=80=9Cdirectory=E2=80=9D) for file/directory names:

  https://www.gnu.org/prep/standards/html_node/GNU-Manuals.html#GNU-Manuals

Really a detail, but I think it=E2=80=99s good to be consistent.

>> >  (define* (base-initrd file-systems
>> >                        #:key
>> >                        (linux linux-libre)
>> > +                      (linux-modules '())
>> >                        (kmod kmod-minimal/static)
>> >                        (mapped-devices '())
>> >                        qemu-networking?=20=20
>>=20
>> We no longer need #:kmod here.
>
> Yes, we do.

I mean in the final version we=E2=80=99ll use the (gnu build linux-modules)=
 I
think, so we won=E2=80=99t need kmod anymore.  Or am I missing something?

Thank you!

Ludo=E2=80=99.