From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esc17-0006xz-33 for guix-patches@gnu.org; Sun, 04 Mar 2018 17:22:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esc13-0008Uc-Pv for guix-patches@gnu.org; Sun, 04 Mar 2018 17:22:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:36888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1esc13-0008U4-N9 for guix-patches@gnu.org; Sun, 04 Mar 2018 17:22:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1esc13-0000Ri-HV for guix-patches@gnu.org; Sun, 04 Mar 2018 17:22:01 -0500 Subject: [bug#29483] [PATCH] services: Add openntpd service. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20171128090443.15544-1-efraim@flashner.co.il> <87lgimiwc2.fsf@gnu.org> <87k1wdh0eo.fsf@gnu.org> <20180129192423.GC17751@macbook41> <871shzbgoz.fsf@gnu.org> <20180302140211.GA3213@macbook41> <871sh2e87t.fsf@gnu.org> <20180304180243.GB1521@macbook41> Date: Sun, 04 Mar 2018 23:21:21 +0100 In-Reply-To: <20180304180243.GB1521@macbook41> (Efraim Flashner's message of "Sun, 4 Mar 2018 20:02:43 +0200") Message-ID: <87y3j732ji.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 29483@debbugs.gnu.org Hello, Efraim Flashner skribis: > On Fri, Mar 02, 2018 at 05:46:30PM +0100, Ludovic Court=C3=A8s wrote: [...] >> To be clear, the switch from =E2=80=98match-lambda=E2=80=99 to =E2=80=98= match-record=E2=80=99 should be >> entirely mechanical. The above snippet would become: >>=20 >> (define (openntpd-shepherd-service config) >> (match-record config >> (openntpd openntpd-listen-on >> openntpd-query-from openntpd-sensor openntpd-server >> openntpd-servers openntpd-constraint-from >> openntpd-constraints-from allow-large-adjustment?) >> =E2=80=A6)) >>=20 >> That=E2=80=99s all I was suggesting. The body of that procedure can rem= ain >> unchanged. >>=20 >> Does that make sense? >>=20 > > Yes, that does make sense. Switching helped me find that I mistakenly > used openntpd- when it should've just been , so I've fixed > that. I've also added a default value field, like the ones that were > recently added for the SQL services, and I tested that it worked with > (service openntpd-service-type) in my test config. Awesome. > From 0c4d07cce671ad9131416f51098082286f241046 Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Tue, 28 Nov 2017 10:19:11 +0200 > Subject: [PATCH] services: Add openntpd service. > > * gnu/packages/ntp.scm (openntpd)[arguments]: Add 'configure-flags to > set openntpd daemon's user and localstatedir. Add a custom phase to not > try to create said directory at install time. > * gnu/services/networking.scm (): New record type. > (openntpd-shepherd-service, openntpd-service-activation): New procedures. > (openntpd-service-type): New variable. > * doc/guix.texi (Networking Services): Add openntpd documentation. [...] > + (constraints-from openntpd-constriants-from ^^ Typo. :-) Got for it! Thank you, Ludo=E2=80=99.