From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSdDq-0003F6-GL for guix-patches@gnu.org; Tue, 12 Jun 2018 02:56:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSdDn-00012k-0f for guix-patches@gnu.org; Tue, 12 Jun 2018 02:56:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36076) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSdDm-00012L-RI for guix-patches@gnu.org; Tue, 12 Jun 2018 02:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSdDm-0007nf-Cl for guix-patches@gnu.org; Tue, 12 Jun 2018 02:56:02 -0400 Subject: bug#31678: [PATCH 2/2] gnu: elixir: Enable more tests and remove patch. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <20180601135106.32680-1-mail@cbaines.net> <20180601135106.32680-2-mail@cbaines.net> <87tvqbgs6t.fsf@member.fsf.org> From: Christopher Baines In-reply-to: <87tvqbgs6t.fsf@member.fsf.org> Date: Tue, 12 Jun 2018 07:55:25 +0100 Message-ID: <87y3fk334y.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: 31678-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > Christopher Baines writes: > >> Previously, due to issues in the erlang package, many tests would fail, = and >> the package would also nondeterministically fail to build. This is now >> fixed (by patching occurances of /bin/sh in the erlang package), so all = the >> tests can be run. >> >> * gnu/packages/elixir.scm (elixir)[source]: Remove patches. The patch is= no >> longer necessary, as all the tests now pass. >> [arguments]: Remove the fix-or-disable-tests phase, all the tests now >> pass. Add a new set-home phase to set the HOME environment variable prio= r to >> running the tests, as that was previously done at the start of the >> fix-or-disable-tests phase. >> * gnu/packages/patches/elixir-disable-failing-tests.patch: Delete this f= ile, >> as it is now unused. > > I think generally we only need to mention the =E2=80=98what=E2=80=99 part= s, not the > =E2=80=98why=E2=80=99 parts (=E2=80=9Cas =E2=80=A6=E2=80=9D) in the per-f= ile details, but I guess it=E2=80=99s nothing > wrong to do it :-) I've pushed this now, thanks for taking a look :) I tweaked the changelog to not repeat the why parts. >> * gnu/local.mk: Remove now deleted patch. > * gnu/local.mk (GNU_SYSTEM_MODULES): ... Missed this bit, only just spotted what you were suggesting, sorry about that. >> --- >> gnu/local.mk | 1 - >> gnu/packages/elixir.scm | 36 +-- >> .../elixir-disable-failing-tests.patch | 284 ------------------ >> 3 files changed, 6 insertions(+), 315 deletions(-) > > Cool, thank you! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlsfbl1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xeqzw/9HOLZY7FAnvRIcNZiUovzKAFonpwWwdk0dohA4A1blIe+MtLZtWxfm8rK WNDhEZS9fKNVKyr+opMbzwK8fJRc0Xvyd9/2UvS8bm2Vg2zF7f3IrND4riS+82b9 h3CXSqsixtLLv9wO3e27Mfc1lHFVIlR13/aL2Mvx69h3bcUHGxJdWNRgmXvlqlH0 lKvMklYlTTjpBk04fGLV7b8tCLC9W22kf1l5SAvkIyxbpJ8PpPxxOmy4ESq9XFmi ZZKKPHxMIwUyp+O/fSL4PizY67V5JpeoEJcPbOntEFXiEsRs0ucavtozYx6vdVMc P6gcAYSObmcGaKaeO78lsDQATvYP3kfes3t31A3kIcffkinOKjylWCAbnyOzW75f lKp2I5W9vJUS7AgxFXYHCD9WCDoZxLbJgFsUs2drXY0zBQb8iyzCE9bPJ5J+YsEp f2FedmxNKUAbRtbBFKOKXSGxmebr7rxM1j+fVAyV74xLvTMi9UWAf3ouGxzZjP5e SVmfpUAPTKatCSK3kY1dopMcmbfG96npZ95WPLlrvRAPt9JQpZ/TZDzNFBd1LnCL V4S07S8mWXuWg2DPYNuec84pCEJ7ADiepC2OF7JuJwNw2LC0gqQcuXl8ghtk+5OB 1qZMt6FZzsFyCjdL3h2LwKCNK7F3DL6tUzkbT+h6avnXKxTZu08= =l2Ft -----END PGP SIGNATURE----- --=-=-=--