From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjtu5-00071d-CB for guix-patches@gnu.org; Sun, 29 Jul 2018 18:11:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjtu2-0004BO-4O for guix-patches@gnu.org; Sun, 29 Jul 2018 18:11:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57372) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjtu1-0004AY-VW for guix-patches@gnu.org; Sun, 29 Jul 2018 18:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fjtu1-0002bX-Na for guix-patches@gnu.org; Sun, 29 Jul 2018 18:11:01 -0400 Subject: [bug#31999] [PATCH 3/7] gnu: Add libbytesize. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180728220706.12904-1-ambrevar@gmail.com> References: <87lgag6w9w.fsf@fastmail.com> <20180728220706.12904-1-ambrevar@gmail.com> Date: Mon, 30 Jul 2018 00:10:32 +0200 Message-ID: <87y3dt3d7r.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Pierre Neidhardt writes: > * gnu/package/c.scm (libbytesize): New variable. [...] > +(define-public libbytesize > + (package > + (name "libbytesize") > + (version "1.3") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/storaged-project/libbytesiz= e") > + (commit version))) > + (file-name (string-append name "-" version "-checkout")) > + (sha256 > + (base32 > + "1ys5d8rya8x4q34gn1hr96z7797s9gdzah0y0d7g84x5x6k50p30"))= )) This project has a release tarball (which are distinct from autogenerated tarballs and won't suddenly change): https://github.com/storaged-project/libbytesize/releases Can you change to use that instead? > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ("gettext" ,gettext-minimal) > + ("pkg-config" ,pkg-config) > + ("python" ,python) > + ("python2" ,python-2) ; For tests. > + ("python2-six" ,python2-six) ; For tests. > + ("python2-polib" ,python2-polib) ; For tests. > + )) Please move these parenthesis up to please 'guix lint'. > + (inputs > + `(("mpfr" ,mpfr) > + ("pcre" ,pcre))) > + (arguments > + `(#:tests? #f ; One test fails because busctl (systemd only?) and > + ; python2-pocketlint are missing. Nit-pick: margin comments are typically not capitalized and has no spacing between the ; and the text. > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'autogen > + (lambda _ > + (invoke "sh" "autogen.sh")))))) Note that since the previous 'core-updates' merge, the equivalent of this should now be invoked automatically if needed. Can you try removing it? If that doesn't work, use (replace 'bootstrap ...) here for clarity. The rest LGTM. > + (home-page "https://github.com/storaged-project/libbytesize") > + (synopsis "Tiny C library for working with arbitrary big sizes in by= tes") > + (description > + "The goal of this project is to provide a tiny library that would > +facilitate the common operations with sizes in bytes. Many projects nee= d to > +work with sizes in bytes (be it sizes of storage space, memory...) and a= ll of > +them need to deal with the same issues like: > + > +@itemize > +@item How to get a human-readable string for the given size? > +@item How to store the given size so that no significant information is = lost? > +@item If we store the size in bytes, what if the given size gets over the > +MAXUINT64 value? > +@item How to interpret sizes entered by users according to their locale = and > +typing conventions? > +@item How to deal with the decimal/binary units (MB versus MiB) ambiguit= y? > +@end itemize > + > +@code{libbytesize} offers a generally usable solution that could be used= by > +every project that needs to deal with sizes in bytes. It is written in = the C > +language with thin bindings for other languages.") > + (license license:lgpl2.1+))) > --=20 > 2.18.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlteO1gACgkQoqBt8qM6 VPoNvwf/QGZWgYZ54/SRjQP4YLo9nivus1gVUu2W/xMeuk92+jeZg+4Sea/svBI5 MVBIwLAvZEWu8JPxhuy+oddzEAmfPLNacS/ww4AlmFfmpbMSvrVXhYJoYmNEKgpN Iu/zDlgbpl8W6DlGI6tHtQNbvCXgXCs1z7gQO9TWkYQSyswCl8A6n82WP9H/lKme CHw1tZV40VJMCAHx+DRfzqrzi+wzC76K71SrulFB4w0QHU1HaHXqml/iGQrH/y5h qFd0H0ju8LJ/hXFsq6s6EZXF1bkstml7J5XSk89ay45Boz7P4jRaV3mayUVmxs8S /Q/9a5Bbbq8lKAT4wWPqqEMfTepU7Q== =xCuw -----END PGP SIGNATURE----- --=-=-=--