unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Meiyo Peng <meiyo@riseup.net>
To: 36273@debbugs.gnu.org
Cc: "Gábor Boskovits" <boskovits@gmail.com>
Subject: [bug#36273] Clarify spdlog's license
Date: Tue, 18 Jun 2019 11:28:59 +0800	[thread overview]
Message-ID: <87y31zpo5g.fsf@riseup.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

Hi Gábor,

The spdlog package contains a bundled fmt library.  I tried to unbundle
fmt before, but the maintaining work does not worth it.  This patch
clarify it's license.

I notice you pushed several Sway related packages into the master
branch, but none of them has been submitted to the mailing list.  Would
you please send you patches to the mailing list first in the future?

You also pushed mako into master, but there is already a discussion
about mako here:
https://lists.gnu.org/archive/html/guix-patches/2019-03/msg00567.html.
We should build mako from it's git master or wait until the next point
release.


--
Meiyo Peng
https://www.pengmeiyu.com/


[-- Attachment #2: 0001-gnu-spdlog-Clarify-license.patch --]
[-- Type: text/x-patch, Size: 1495 bytes --]

From 8e3714e847e62e8bec86f2f90cf6e12399280391 Mon Sep 17 00:00:00 2001
From: Meiyo Peng <meiyo@riseup.net>
Date: Tue, 18 Jun 2019 11:07:50 +0800
Subject: [PATCH] gnu: spdlog: Clarify license.

* gnu/packages/logging.scm (spdlog): Clarify license of the bundled fmt
  library.
---
 gnu/packages/logging.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index e936733136..24a47567d0 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2017 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2019 Gábor Boskovits <boskovits@gmail.com>
+;;; Copyright © 2019 Meiyo Peng <meiyo@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -205,5 +206,8 @@ windows in a terminal, colorize, filter and merge.")
        (list "-DSPDLOG_BUILD_BENCH=OFF")))
     (home-page "https://github.com/gabime/spdlog")
     (synopsis "Fast C++ logging library")
-    (description "Spdlog is a very fast header-only/compiled C++ logging library.")
-    (license license:expat))) ; MIT license
+    (description "Spdlog is a very fast header-only/compiled C++ logging
+library.")
+    ;; spdlog is under Expat license, but the bundled fmt library in
+    ;; "include/spdlog/fmt/bundled" is under BSD 2 clause license.
+    (license (list license:expat license:bsd-2))))
-- 
2.22.0


             reply	other threads:[~2019-06-18  3:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18  3:28 Meiyo Peng [this message]
2019-06-19  8:05 ` [bug#36273] Clarify spdlog's license Gábor Boskovits
2019-06-20  3:44 ` bug#36273: " Gábor Boskovits

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y31zpo5g.fsf@riseup.net \
    --to=meiyo@riseup.net \
    --cc=36273@debbugs.gnu.org \
    --cc=boskovits@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).