From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41074)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfKTL-00045l-0o
 for guix-patches@gnu.org; Mon, 24 Jun 2019 04:37:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfKTI-0003Qa-7p
 for guix-patches@gnu.org; Mon, 24 Jun 2019 04:37:06 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41999)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hfKTF-0003N4-VP
 for guix-patches@gnu.org; Mon, 24 Jun 2019 04:37:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hfKTF-00025v-PY
 for guix-patches@gnu.org; Mon, 24 Jun 2019 04:37:01 -0400
Subject: [bug#35790] [PATCH] scripts: lint: Separate the message warning text
 and data.
Resent-Message-ID: <handler.35790.B35790.15613654208044@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87pnnpj15u.fsf@gnu.org> <20190616125608.15690-1-mail@cbaines.net>
Date: Mon, 24 Jun 2019 10:36:43 +0200
In-Reply-To: <20190616125608.15690-1-mail@cbaines.net> (Christopher Baines's
 message of "Sun, 16 Jun 2019 13:56:08 +0100")
Message-ID: <87y31rcrc4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 35790@debbugs.gnu.org

Hello,

Christopher Baines <mail@cbaines.net> skribis:

> +(define-syntax make-warning
> +  (syntax-rules (G_)
> +    ((_ package (G_ message) rest ...)
> +     (%make-warning package message rest ...))
> +    ((_ package message rest ...)
> +     (%make-warning package message rest ...))))

I think you can remove the second clause: that will ensure we never
forget to add a G_ around messages.

Otherwise LGTM!

Ludo=E2=80=99.