From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:34658)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hgQZf-00034E-HZ
 for guix-patches@gnu.org; Thu, 27 Jun 2019 05:20:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hgQZY-00066Z-T2
 for guix-patches@gnu.org; Thu, 27 Jun 2019 05:20:08 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:52108)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hgQZX-00065v-0I
 for guix-patches@gnu.org; Thu, 27 Jun 2019 05:20:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hgQZW-0004ZZ-PB
 for guix-patches@gnu.org; Thu, 27 Jun 2019 05:20:02 -0400
Subject: bug#36390: [PATCH 0/3] Improve 'guix search' relevance and display
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.36390.D36390.156162716917531.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190626084338.3153-1-ludo@gnu.org> <87ef3gsm8e.fsf@elephly.net>
Date: Thu, 27 Jun 2019 11:19:20 +0200
In-Reply-To: <87ef3gsm8e.fsf@elephly.net> (Ricardo Wurmus's message of "Wed,
 26 Jun 2019 11:57:05 +0200")
Message-ID: <87y31n2xnr.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 36390-done@debbugs.gnu.org

Hello!

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> This improves =E2=80=98guix search=E2=80=99 in two ways:
>>
>>   1. The relevance score now excludes things that do not match *all*
>>      the regexps.  So =E2=80=98guix search go game=E2=80=99 returns 28 r=
esults instead
>>      of 1,245 and the first one is =E2=80=98gnugo=E2=80=99; =E2=80=98gui=
x search ssh client=E2=80=99
>>      returns 14 results instead of 510; =E2=80=98guix search guile crypt=
o=E2=80=99
>>      returns just =E2=80=98guile-gcrypt=E2=80=99 instead of 279 results.
>>
>>   2. =E2=80=98guix search=E2=80=99 and =E2=80=98guix system search=E2=80=
=99 now write at most a full
>>      screen of results.  You can pipe through a pager to view all the
>>      results.
>
> Perfect, thank you for the patches!

It seems rather non-controversial.  :-)

Pushed:

  4311cf965c ui: Add 'display-search-results' and use it.
  4593f5a654 syscalls: Add 'terminal-rows'.
  8874faaaac ui: 'relevance' considers regexps connected with a logical and.

> (I wonder why you chose to use =E2=80=9C(cut > <> 0)=E2=80=9D instead of =
=E2=80=9Cpositive?=E2=80=9D for
> checking if a value is greater than zero.)

Actually no good reasons, I wanted to amend it and then forgot.

Thanks,
Ludo=E2=80=99.