From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:56445)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hizlZ-0001Sd-HL
 for guix-patches@gnu.org; Thu, 04 Jul 2019 07:19:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hizlX-0006yH-Jf
 for guix-patches@gnu.org; Thu, 04 Jul 2019 07:19:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41643)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hizlW-0006xd-Kn
 for guix-patches@gnu.org; Thu, 04 Jul 2019 07:19:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hizlW-0004sL-FB
 for guix-patches@gnu.org; Thu, 04 Jul 2019 07:19:02 -0400
Subject: [bug#36469] [PATCH 2/2] pack: 'squashfs' backend records the
 profile's search paths.
Resent-Message-ID: <handler.36469.B36469.156223908318662@debbugs.gnu.org>
References: <20190702085601.10865-1-ludo@gnu.org>
 <20190702085601.10865-2-ludo@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190702085601.10865-2-ludo@gnu.org>
Date: Thu, 04 Jul 2019 13:17:54 +0200
Message-ID: <87y31erqu5.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 36469@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludovic.courtes@inria.fr>


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> From: Ludovic Court=C3=A8s <ludovic.courtes@inria.fr>
>
> * guix/scripts/pack.scm (singularity-environment-file): New procedure.
> (squashfs-image): Use it, and create /.singularity/env/90-environment.sh.
> * gnu/tests/singularity.scm (run-singularity-test)["singularity run,
> with environment"]: New test, currently skipped.
> * gnu/tests/singularity.scm (build-tarball&run-singularity-test): Add
> GUILE-JSON to the profile.

This looks good to me.

I think it would be good to separate squashfs-image and singularity
going forward as we discussed earlier, but for now mixing the two is
fine.

Thanks!

--
Ricardo