From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:44030)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4HD-0007cv-OI
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:08:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4HC-0001uH-O2
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:08:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42951)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hj4HC-0001tw-Dc
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:08:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4HC-0003oi-7T
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:08:02 -0400
Subject: bug#36213: [PATCH 4/4] gnu: Add pulseaudio-dlna.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.36213.D36213.156225644314595.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <9f57b4cb-e4e9-4dfa-9308-9263b5edfe23@www.fastmail.com>
 <3ee05f72-19df-4eb0-89c0-37ddded34d57@www.fastmail.com>
 <87lfxg5t4y.fsf@gnu.org>
 <76eb1a48-171f-4e2c-9d3e-845f6dbcd0ea@www.fastmail.com>
Date: Thu, 04 Jul 2019 18:07:05 +0200
In-Reply-To: <76eb1a48-171f-4e2c-9d3e-845f6dbcd0ea@www.fastmail.com> (Alex
 Griffin's message of "Tue, 02 Jul 2019 16:01:27 +0000")
Message-ID: <87y31d2386.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: 36213-done@debbugs.gnu.org

Hi,

"Alex Griffin" <a@ajgrf.com> skribis:

> On Tue, Jul 2, 2019, at 3:54 PM, Ludovic Court=C3=A8s wrote:
>> > +(define-public pulseaudio-dlna
>> > +  (let ((commit "4472928dd23f274193f14289f59daec411023ab0")
>> > +        (revision "1"))
>>=20
>> Could you explain why you chose this commit rather than the latest
>> release?
>
> Honestly, I just noticed that Debian was building from git. I assumed the=
y had a good reason, so I didn't even try the latest release from 2016.

OK.  There have been quite a few commits since that 2016 release, so it
probably makes sense to use the latest one.

>> > +      (arguments `(#:python ,python-2))
>>=20
>> Can it run on Python 3?
>>=20
>> Since Python 2 is approaching EOL, we=E2=80=99re trying to avoid adding =
more
>> Python 2 packages.  If we could remove =E2=80=98python2-=E2=80=99 packag=
es from this
>> patch series, that=E2=80=99d be great; if not, so be it!
>
> No, it doesn't run on Python 3. It's actually unmaintained right now, but=
 I'm not aware of any other free software projects that provide the same fu=
nctionality.

OK.

I took the liberty to add some of what you wrote as comments in the
code and pushed the whole series.

Thanks!

Ludo=E2=80=99.