From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39569)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i6hYx-0005II-7t
 for guix-patches@gnu.org; Sat, 07 Sep 2019 16:44:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i6hYw-0003OS-5G
 for guix-patches@gnu.org; Sat, 07 Sep 2019 16:44:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57538)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1i6hYv-0003O7-Sh
 for guix-patches@gnu.org; Sat, 07 Sep 2019 16:44:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i6hYv-0000JN-NQ
 for guix-patches@gnu.org; Sat, 07 Sep 2019 16:44:01 -0400
Subject: [bug#37329] [PATCH] gnu: Add audacious.
Resent-Message-ID: <handler.37329.B37329.15678890131140@debbugs.gnu.org>
References: <20190907045755.6578-1-kkebreau@posteo.net> <87ef0swcrf.fsf@nckx>
 <87imq4xiil.fsf@posteo.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87imq4xiil.fsf@posteo.net>
Date: Sat, 07 Sep 2019 22:43:23 +0200
Message-ID: <87y2yzu9as.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 37329@debbugs.gnu.org


Kei Kebreau <kkebreau@posteo.net> writes:

>>> +    (arguments
>>> +     `(#:configure-flags
>>> +       (list "--disable-gtk" "--enable-qt"
>
> In reply to your later email: I used Qt instead of the default GTK+ 2
> because of a personal preference, but apparently it's possible to enable
> both to let users choose what they prefer.

Would this retain references to *both* toolkits?  Wouldn=E2=80=99t this mak=
e the
package much bigger than it otherwise would be?

What=E2=80=99s the smaller variant=E2=80=A6?

>>> +       #:phases
>>> +       (modify-phases %standard-phases
>>> +         (add-after 'install 'unpack-plugins
>>> +           (lambda* (#:key inputs #:allow-other-keys)
>>> +             (let ((plugins (assoc-ref inputs
>>> "audacious-plugins")))
>>> +               (invoke "tar" "xvf" plugins)
>>> +               (chdir (string-append "audacious-plugins-"=20
>>> ,version))
>>
>> It's not wrong, and I know this saves (with-directory-excursion)s down
>> the road, but brr.  :-)
>>
>
> Is it the lack of clarity in later phases that's undesirable?

It=E2=80=99s a littly icky to have phases modify global state (other than t=
he
files they operate on), because it is no longer enough to look at just=20
the phase of interest.  If it can be avoided without making things too
ugly I=E2=80=99d prefer to avoid =E2=80=9Cchdir=E2=80=9D here.

--=20
Ricardo