From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56824) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDF6Z-0003kv-CL for guix-patches@gnu.org; Sat, 14 Mar 2020 18:18:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDF6Y-00061P-Es for guix-patches@gnu.org; Sat, 14 Mar 2020 18:18:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDF6Y-00060q-37 for guix-patches@gnu.org; Sat, 14 Mar 2020 18:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDF6X-00060s-VN for guix-patches@gnu.org; Sat, 14 Mar 2020 18:18:01 -0400 Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-Message-ID: References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> <20200314172114.GA23019@jasmine.lan> In-reply-to: Date: Sat, 14 Mar 2020 23:17:42 +0100 Message-ID: <87y2s2lgxl.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: Leo Famulari , 40060@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hullo Brice, Thanks for the patch! Brice Waegeneire =E5=86=99=E9=81=93=EF=BC=9A > I should have written this in the cover-letter, my bad. > pycryptodome is needed for the hlsative downloader, ffmpeg adds=20 > the > ability to merge video and audio files downloaded separately by > youtube-dl and removes the following warning: > WARNING: You have requested multiple formats but ffmpeg or=20 > avconv are > not installed. The formats won't be merged. This message is one of the best I've seen. It clearly explains to=20 the user what's (not) going to happen, and what they can do to=20 change that *if* they want to. Hence I think adding ffmpeg as a=20 hard dependency is incorrect. (I'd also oppose a youtube-dl-full variant, by the way. Packages=20 aren't the right place for this; profiles are.) Does youtube-dl print a similarly clear message when pycryptodome=20 is needed but missing? If not, that addition LGTM with a ("pycryptodome" ,pycryptodome) ; for the hlsnative downloader comment. Cover letters & commit messages age badly. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl5tWAYACgkQ2Imw8BjF STwJEg/+KkvVaMzy7eZytF1F/2CzmrH/8BxsTOTrMihbTI3eMlfsLn6DCQeeBCjH uZ8Dm/JDzoaiQVqt3MS1dYmoDdWGSNb5+q/EEbYyD9PLRzfPPUe7QwVHvbC4NnLG D4UYOK0mX/fNKMPUPXEJWqpCeGUaf2feqDqpTU9JDAgBBbVdMPqeMFiq70YEA/rW sp6fPoazHTmGZs01Url4a1+xpmg8+z8oGiDX1nGAnlGkNHkM5N/7+NpjEgQ+7WLN Edb8ABDyXN+ukpJ877l7zYFgS2kkckNqwNICdiHrR8neBsKoQVq+ua/sVHZAcnHP 9E3nX4IgmoCdB043Y2h4EPBuq8hL6MBH3z1C56eC3S/pJqJuGzyhMf3lE7nT8ZTF 0yaFQXJXSz9N350qo3TmfjTjNpJFOtdZjtxLoDtyjIJuzEUf4efFA0SPdWldpN+w TEAwQvDX32ygjkazPGSWr5tO1ayxm31k7N1w6Q0CgjwBU6jycrg7Beu/8GxAqUKP GU1F9Nuky0z8DUhP0yl9hadVD9vLRm6bve3cdifrsAfiK4feYTeTWCbHy2F/J9eb UUn+q52qBoSSNUj0ZzQd9LiDMak4F3aPVj+ssUJK0z5xQifrm21akswHwDQWbE8J 2d2dB4KBTemA2bKJSKT8r8P+z4/4X2hsIa/ZNIwXD4MfcB8s1f0= =hivP -----END PGP SIGNATURE----- --=-=-=--