From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:42054)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMwwl-0007L0-6D
 for guix-patches@gnu.org; Fri, 10 Apr 2020 12:56:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMwwk-0004Fc-5w
 for guix-patches@gnu.org; Fri, 10 Apr 2020 12:56:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:44436)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jMwwj-0004FK-Ve
 for guix-patches@gnu.org; Fri, 10 Apr 2020 12:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMwwj-0005f3-UH
 for guix-patches@gnu.org; Fri, 10 Apr 2020 12:56:01 -0400
Subject: [bug#40543] [PATCH 4/4] gnu: virt-manager: Work towards enabling some
 tests.
Resent-Message-ID: <handler.40543.B40543.158653770721690@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <20200410162157.21065-4-mail@cbaines.net>
References: <87wo6n726x.fsf@cbaines.net>
 <20200410162157.21065-1-mail@cbaines.net>
 <20200410162157.21065-4-mail@cbaines.net>
Date: Fri, 10 Apr 2020 18:54:58 +0200
Message-ID: <87y2r3i8m5.fsf@devup.no>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>, 40543@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/virtualization.scm (virt-manager)[arguments]: Set #:test-target
> to "test_ui", replace the 'check phase.
> [native-inputs]: Add some inputs required for running tests.

[...]

> @@ -673,6 +684,11 @@ virtualization library.")
>         ("gobject-introspection" ,gobject-introspection)
>         ("gtk+" ,gtk+ "bin")             ; gtk-update-icon-cache
>         ("perl" ,perl)                   ; pod2man
> +       ("python-dogtail" ,python-dogtail)
> +       ("xvfb" ,xorg-server)
> +       ("dbus" ,dbus)
> +       ("at-spi2-core" ,at-spi2-core)
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)

Please leave a comment along the lines of

;; The following are required for running the tests.

...to leave a clue for the next packager who wonders whether these
inputs are misplaced.

Apart from these comments, the series LGTM.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6QpOIACgkQoqBt8qM6
VPpW3wf/UGS+raJ/99xGNEvLw1vySQ9pMNV/ONckgAolWMHGxRtMV+qmYzDbB2lm
igjyXXMGDCOn1bKp314JLi0OaQSUT9kaR3vbmgFSaTQiC35ng2sn8q9Vo62uk2mp
8cD82ltOnsLkKHOjNIa4+O4gAIY47WIwAPb/Ua/HSpIR/rhPRjpkv8i3FrSstE4f
zS8YCrkLZmnU5dH66eyYX/62+KtK3e6CIfyycjKN235uLaEA7379DaYed3gGrrlX
hwiPcYQGC9aXNSJBCV0c5zh1NylXFJw0sREr3YDMcOXbdH8BpjWQKQqb3VhJ9JEq
6b+k+31RJ/0tyRZTwlvfET6+nq9zYA==
=W0OU
-----END PGP SIGNATURE-----
--=-=-=--