From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56696) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNheG-0005Ab-2V for guix-patches@gnu.org; Sun, 12 Apr 2020 14:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNheE-00075k-Uk for guix-patches@gnu.org; Sun, 12 Apr 2020 14:48:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47325) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNheE-00075b-Mj for guix-patches@gnu.org; Sun, 12 Apr 2020 14:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNheE-0008Le-Lo for guix-patches@gnu.org; Sun, 12 Apr 2020 14:48:02 -0400 Subject: [bug#40579] [RFC PATCH] add iPXE. Resent-Message-ID: References: In-reply-to: Date: Sun, 12 Apr 2020 20:47:23 +0200 Message-ID: <87y2r0mthg.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: 40579@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Vincent, Thank you! Brief review, will build & maybe notice more later: Vincent Legoll =E5=86=99=E9=81=93=EF=BC=9A > The licensing is "interesting", see: > > https://ipxe.org/licensing > > Is that a problem ? Could you elaborate? What's "interesting" about it? That all=20 looks very boring and straightforward to me (which is good! :-) =E2=80=94=20 the result is GPL2-only, no? + (file-name (string-append name "-" version=20 "-checkout")) You can use the GIT-FILE-NAME helper here. + `(#:phases (modify-phases %standard-phases Aside: I'd indent arguments' #:keywords as + `(#:phases + (modify-phases %standard-phases to give you more breathing room at deeper indentation levels.=20 It's not needed now, but if someone were to add a new phase they might have to do annoying things, or re-indent the entire thing later, causing noise. Maybe that's=20 just me though. + (add-after 'unpack 'add-real-make-install + (lambda* (#:key outputs #:allow-other-keys) + (substitute* "src/Makefile" + (("^install :") + (string-append "install :" + "\n\t@$(MKDIR) -p " + (assoc-ref outputs "out")=20 "/bin" + "\n\t@$(CP) $(ALL) " + (assoc-ref outputs "out")=20 "/bin" + "\n\n__old_install :"))) Interesting approach! I'm OK with it; looking at ALL it wouldn't=20 be more readable or future-proff to use FIND-FILES & Scheme. /bin is not the right place for these files. /lib/ipxe looks to=20 be the standard; let's use that. + (replace 'build + (lambda _ (with-directory-excursion "src" + (invoke "make" "-j"=20 (number->string +=20 (parallel-job-count)))))) Let's, instead: (add-after 'unpack 'enter-source-directory (lambda _ (chdir "src") #t)) Don't worry, the state can't hurt you now. Now we can keep the=20 standard build & install phases. It might be necessary to add a =E2=80=98leave-source-directory=E2=80=99 aft= er=20 'install to make sure the licence files are still installed to=20 share/doc/. + #:tests? #f)) =E2=86=92 #:tests? #f)) ; no test suite + (native-inputs Nitpick: sort? :-) + (synopsis "PXE-compliant network boot firmware") I personally like the =E2=80=98these are just boot loaders=E2=80=99 angle, = but=20 would users expect to find this in (gnu packages firmware)=20 instead? Shrug. + (license license:gpl2+))) =E2=80=98gpl2=E2=80=99 as mentioned above. If you feel like it (there aren't that many files) you could list=20 the licences for each output binary, but that's optional. The=20 combined work appears to be GPL2. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6TYjwACgkQ2Imw8BjF STwLGRAApmpsVYVJSUS7a0jFmuOVXPnJrSlrQA2AeF7gZdSKDa5xMh3R1wPVzR0j dgGiW/YqxDgeo05i/eI4m/4gzYA361s01E1y6+kyJVMF9mcp8yYZiHedvMnKvG8w a/E7hqeUUVjAPWljEsxAO5LWJX9JqQE8vRU7xryBta9ee5sAYPt9DntjtC+W4o18 FSl+IyEnXqHUXb0NXdFUlV38Gyw/Ily+Wny1hl6plfyvZf2dMirbdToRAy1hMCor D7nMTuPXrFO2o5kSYPmmKBmKHLQl8Gmxm31UuI3xUjEdpcv3qoNr6B9KQmF8/TLF fXHIDSLFjZhtUlYA+cuhaNiArsI0GcgYEDJMRoUsKWH2YC28bEBfzvk2KTVK5tVX LhCIvtHLPyQSy8LVuoGD4rndKMRvkfNC51sR812NI//ZxDyzKdc5XqsA+aLTCO1D VFxLO37iexCcXx2MU7WxxPB+y48NZEuMm4xTZH+i7A5jv7wqTb3MZZlGzV6fApow bgps65fOI2Hqgfmk+qC7BvBFfEv0SMdDdtk01K9I+1pIf7H+ij+smJlvKsirWlUF ZyrN2LQXEilATtBlRKHfzulUkf2aE21P2S2Fmy8HZMvZFQ7m9weMBoMAyoJ6VbwT NXAJD86V1cjGS7tNoTbTMOT8Xa/4jCoBFPgD1yfoAbzMD5FngWI= =57Y5 -----END PGP SIGNATURE----- --=-=-=--