unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: goodoldpaul@autistici.org
Cc: 41056-done@debbugs.gnu.org
Subject: bug#41056: [PATCH 2/2] gnu: nix: Update to 2.3.4.
Date: Wed, 06 May 2020 22:46:49 +0200	[thread overview]
Message-ID: <87y2q43i6e.fsf@devup.no> (raw)
In-Reply-To: <64a1e6cbe82f9950eae02d3abb610adf@autistici.org>

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

goodoldpaul@autistici.org writes:

> Hi Marius,
>
> On 2020-05-05 17:48, Marius Bakke wrote:
>> Giacomo Leidi <goodoldpaul@autistici.org> writes:
>> 
>>> * gnu/packages/package-management.scm (nix): Update to 2.3.4,
>>> [native-inputs]: Add autoconf, autoconf-archive, automake, bison and 
>>> flex,
>>> [inputs]: Add boost, brotli, editline.
>> 
>> The new native-inputs are weird.  Do you know why they are needed?
>> Typically those are only necessary when building from a git checkout,
>> not for release tarballs.
>
> Of course they are strange, I was trying to use the Git checkout 
> initially because of the wonderful support offered by SWH in storing Git 
> repositories but eventually I changed my mind and forgot to remove them 
> :(.

Easy mistake to make :-) good thing we have patch review processes to
catch such issues!

> I fixed this and the problems in the other patch and I'm going to send 
> an updated version.

Applied both patches, thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-05-06 20:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03 17:45 [bug#41056] [PATCH] gnu: nix: Update to 2.3.4 goodoldpaul
2020-05-03 17:46 ` [bug#41056] [PATCH 1/2] gnu: Add editline Giacomo Leidi
2020-05-03 17:46   ` [bug#41056] [PATCH 2/2] gnu: nix: Update to 2.3.4 Giacomo Leidi
2020-05-05 17:48     ` Marius Bakke
2020-05-05 20:53       ` goodoldpaul
2020-05-06 20:46         ` Marius Bakke [this message]
2020-05-05 17:44   ` [bug#41056] [PATCH 1/2] gnu: Add editline Marius Bakke
2020-05-05 20:53 ` Giacomo Leidi
2020-05-05 20:53   ` [bug#41056] [PATCH 2/2] gnu: nix: Update to 2.3.4 Giacomo Leidi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2q43i6e.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=41056-done@debbugs.gnu.org \
    --cc=goodoldpaul@autistici.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).