unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: 41150@debbugs.gnu.org
Cc: me@tobias.gr
Subject: [bug#41150] [PATCH] gnu: Add powerstat.
Date: Sat, 09 May 2020 19:01:40 +0200	[thread overview]
Message-ID: <87y2q1yrd7.fsf@gnu.org> (raw)
In-Reply-To: <20200509151509.11424-1-me@tobias.gr> (Tobias Geerinckx-Rice via Guix-patches via's message of "Sat, 9 May 2020 17:15:09 +0200")


Hey Tobias,

> +    (arguments
> +     `(#:make-flags
> +       (list "CC=gcc"

Hard-coding CC this way will prevent cross-compilation. You can have a
look to "crda" or "libaio" for examples.

As this is a recurring pattern, we should find a way to add it somewhere
in the build-system. But for now, the ugly snippet appending target
should work :).

Otherwise this looks fine!

Thanks,

Mathieu




  reply	other threads:[~2020-05-09 18:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 15:15 [bug#41150] [PATCH] gnu: Add powerstat Tobias Geerinckx-Rice via Guix-patches via
2020-05-09 17:01 ` Mathieu Othacehe [this message]
2020-05-09 17:32   ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-09 20:03     ` Jean-Baptiste Note
2020-05-09 21:04       ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-09 21:10         ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-09 20:42   ` bug#41150: " Tobias Geerinckx-Rice via Guix-patches via
2020-05-10  7:24     ` [bug#41150] " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2q1yrd7.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=41150@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).