From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qLF/NVvKJ18ETAAA0tVLHw (envelope-from ) for ; Mon, 03 Aug 2020 08:27:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qPBOMVvKJ1+TTQAA1q6Kng (envelope-from ) for ; Mon, 03 Aug 2020 08:27:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3EB069404C7 for ; Mon, 3 Aug 2020 08:27:07 +0000 (UTC) Received: from localhost ([::1]:51440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2VoI-0003mt-8c for larch@yhetil.org; Mon, 03 Aug 2020 04:27:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2VoE-0003mU-9j for guix-patches@gnu.org; Mon, 03 Aug 2020 04:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2VoE-00058l-1U for guix-patches@gnu.org; Mon, 03 Aug 2020 04:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k2VoD-000823-Up for guix-patches@gnu.org; Mon, 03 Aug 2020 04:27:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42682] [PATCH 2/2] gnu: Add qmk-cli. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 Aug 2020 08:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42682 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jan Wielkiewicz Cc: 42682@debbugs.gnu.org Received: via spool by 42682-submit@debbugs.gnu.org id=B42682.159644317530816 (code B ref 42682); Mon, 03 Aug 2020 08:27:01 +0000 Received: (at 42682) by debbugs.gnu.org; 3 Aug 2020 08:26:15 +0000 Received: from localhost ([127.0.0.1]:44197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2VnS-00080x-Sy for submit@debbugs.gnu.org; Mon, 03 Aug 2020 04:26:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2VnR-00080h-JC for 42682@debbugs.gnu.org; Mon, 03 Aug 2020 04:26:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36334) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2VnL-00051B-BR; Mon, 03 Aug 2020 04:26:08 -0400 Received: from [2a01:cb18:832e:5f00:b06a:601:6fcc:d1cf] (port=52848 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k2VnJ-00078p-SZ; Mon, 03 Aug 2020 04:26:06 -0400 From: Mathieu Othacehe References: <20200802204910.15356-1-tona_kosmicznego_smiecia@interia.pl> <20200802204910.15356-2-tona_kosmicznego_smiecia@interia.pl> Date: Mon, 03 Aug 2020 10:26:03 +0200 In-Reply-To: <20200802204910.15356-2-tona_kosmicznego_smiecia@interia.pl> (Jan Wielkiewicz's message of "Sun, 2 Aug 2020 22:49:10 +0200") Message-ID: <87y2mwt9t0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: tgZpCA6id4CY > + (propagated-inputs > + `(("arm-none-eabi-gcc" ,gcc-arm-none-eabi-7-2018-q2-update) > + ("avr-gcc" ,avr-toolchain-5) > + ("avrdude" ,avrdude) > + ("dfu-programmer" ,dfu-programmer) > + ("dfu-util" ,dfu-util) > + ("git" ,git) > + ("python3" ,python) > + ("python-appdirs" ,python-appdirs) > + ("python-argcomplete" ,python-argcomplete) > + ("python-colorama" ,python-colorama) > + ("python-flake8" ,python-flake8) > + ("python-hjson" ,python-hjson) > + ("python-nose2" ,python-nose2) > + ("python-yapf" ,python-yapf))) Do we really need to propagate all those inputs? Can't we hardcode the path to those tools directly in the sources, if they are not registered at build time? > + (arguments > + `(#:phases (modify-phases %standard-phases > + (add-before 'check 'set-qmk-home > + (lambda _ > + ;; tests fail without this variable set > + (setenv "QMK_HOME" > + "") Who is supposed to set it otherwise? > + "A program to help users work with QMK Firmware.") You also need to elaborate here :) Thanks, Mathieu