From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YPPzNekWXl+vbgAA0tVLHw (envelope-from ) for ; Sun, 13 Sep 2020 12:56:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yMI/MOkWXl8cYAAA1q6Kng (envelope-from ) for ; Sun, 13 Sep 2020 12:56:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A2659408DA for ; Sun, 13 Sep 2020 12:56:09 +0000 (UTC) Received: from localhost ([::1]:49240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHRY8-0000XU-2d for larch@yhetil.org; Sun, 13 Sep 2020 08:56:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHRY2-0000X6-4F for guix-patches@gnu.org; Sun, 13 Sep 2020 08:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38131) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHRY1-0003hC-Q5 for guix-patches@gnu.org; Sun, 13 Sep 2020 08:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHRY1-0001DU-OT for guix-patches@gnu.org; Sun, 13 Sep 2020 08:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43193] [PATCH] guix: Add --with-dependency-source option Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Sep 2020 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43193 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jesse Gibbons Cc: 43193@debbugs.gnu.org Received: via spool by 43193-submit@debbugs.gnu.org id=B43193.16000017464655 (code B ref 43193); Sun, 13 Sep 2020 12:56:01 +0000 Received: (at 43193) by debbugs.gnu.org; 13 Sep 2020 12:55:46 +0000 Received: from localhost ([127.0.0.1]:49677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRXm-0001D1-0U for submit@debbugs.gnu.org; Sun, 13 Sep 2020 08:55:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRXk-0001Cp-RI for 43193@debbugs.gnu.org; Sun, 13 Sep 2020 08:55:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57785) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHRXe-0003ei-UP; Sun, 13 Sep 2020 08:55:39 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47026 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHRXd-0005c1-MP; Sun, 13 Sep 2020 08:55:38 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <9c3a00ba-19bf-a8e9-8803-d150e91f1b6e@gmail.com> <87y2lige5l.fsf@gnu.org> <7f52c72f-c280-b585-d1ad-ca012f804910@gmail.com> <87wo10s4j6.fsf@gnu.org> <4c890f8c-539c-1c9c-f558-7ba01cffa480@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 13 Sep 2020 14:55:28 +0200 In-Reply-To: <4c890f8c-539c-1c9c-f558-7ba01cffa480@gmail.com> (Jesse Gibbons's message of "Fri, 11 Sep 2020 12:28:31 -0600") Message-ID: <87y2ld7s5b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 1tWgCNgG7ztw Hi, Jesse Gibbons skribis: > On 9/11/20 9:43 AM, Ludovic Court=C3=A8s wrote: [...] >> So maybe drop the second clause for non-recursive replacement, and drop >> =E2=80=98transform-package-source=E2=80=99 as well. > I included a fallback to transform-package-source because the > following happens: > > $ ./pre-inst-env guix build --with-source=3D$(guix build --source hello) = hello > guix build: error: invalid source replacement specification: > "/gnu/store/hbdalsf5lpf01x4dcknwx6xbn6n5km6k-hello-2.10.tar.gz" > > This does not fail when I fall back to the non-recursive logic. > > I can drop transform-package-source, but I will need to do some more > hacking to figure out how the package name and version are parsed from=20 > the file name as described in the manual, and move it to the logic in > transform-package-inputs/source. Yes, that=E2=80=99d be nice. Namely, if you do: guix build hello --source=3Dhello-1.2.3.tar.gz it should work just as now (from the source file name, we assume that the source applies to package =E2=80=9Chello=E2=80=9D). Conversely, doing: guix build hello --source=3Dxyz-hello-1.2.3.tar.gz would have no effect. It would not even emit a warning, unlike now. > I'm not going to have as much free time starting next week, so I might > not be able to do that for a while, but I will try to get it done > ASAP. Sure, let=E2=80=99s stay in touch, I think we=E2=80=99re almost done! Thank you, Ludo=E2=80=99.