From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kN2KOQzTel8obgAA0tVLHw (envelope-from ) for ; Mon, 05 Oct 2020 08:02:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QKBiNQzTel9bDQAAbx9fmQ (envelope-from ) for ; Mon, 05 Oct 2020 08:02:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 692899400D3 for ; Mon, 5 Oct 2020 08:02:20 +0000 (UTC) Received: from localhost ([::1]:51124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPLRp-0002w1-Uf for larch@yhetil.org; Mon, 05 Oct 2020 04:02:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPLRc-0002vJ-6P for guix-patches@gnu.org; Mon, 05 Oct 2020 04:02:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPLRb-0004XH-0O for guix-patches@gnu.org; Mon, 05 Oct 2020 04:02:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPLRa-0003Y7-Uc for guix-patches@gnu.org; Mon, 05 Oct 2020 04:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43494] [PATCH v2 4/4] services: guix: Add guix-build-coordinator-queue-builds-service-type. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Oct 2020 08:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 43494@debbugs.gnu.org Received: via spool by 43494-submit@debbugs.gnu.org id=B43494.160188486610786 (code B ref 43494); Mon, 05 Oct 2020 08:02:02 +0000 Received: (at 43494) by debbugs.gnu.org; 5 Oct 2020 08:01:06 +0000 Received: from localhost ([127.0.0.1]:47728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLQf-0002n4-Ba for submit@debbugs.gnu.org; Mon, 05 Oct 2020 04:01:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLQd-0002gN-DB for 43494@debbugs.gnu.org; Mon, 05 Oct 2020 04:01:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54259) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPLQX-0004PD-On; Mon, 05 Oct 2020 04:00:57 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=33900 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kPLQW-0007z2-Ck; Mon, 05 Oct 2020 04:00:57 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200919101059.8930-1-mail@cbaines.net> <20200919101059.8930-4-mail@cbaines.net> Date: Mon, 05 Oct 2020 10:00:55 +0200 In-Reply-To: <20200919101059.8930-4-mail@cbaines.net> (Christopher Baines's message of "Sat, 19 Sep 2020 11:10:59 +0100") Message-ID: <87y2kl5cg8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: Pzrkfxa4zivp Hi Chris, Sorry for the delay. Patches 1=E2=80=933 LGTM! One minor comment on patch= 4: Christopher Baines skribis: > * gnu/services/guix.scm (): > New record type. > (guix-build-coordinator-queue-builds-configuration, > guix-build-coordinator-queue-builds-configuration?, > guix-build-coordinator-queue-builds-configuration-package, > guix-build-coordinator-queue-builds-configuration-user, > guix-build-coordinator-queue-builds-coordinator, > guix-build-coordinator-queue-builds-configuration-systems, > guix-build-coordinator-queue-builds-configuration-system-and-targets, > guix-build-coordinator-queue-builds-configuration-guix-data-service, > guix-build-coordinator-queue-builds-configuration-processed-commits-file, > guix-build-coordinator-queue-builds-shepherd-services, > guix-build-coordinator-queue-builds-activation, > guix-build-coordinator-queue-builds-account): New procedures. > (guix-build-coordinator-queue-builds-service-type): New variable. [...] >=20=20 > +@defvar {Scheme Variable} guix-build-coordinator-queue-builds-service-ty= pe > +Service type for the > +guix-build-coordinator-queue-builds-from-guix-data-service script. Its > +value must be a @code{guix-build-coordinator-queue-builds-configuration} > +object. > +@end defvar Could you add a paragraph right above this explaining what this service is about? > +(define guix-build-coordinator-queue-builds-service-type > + (service-type > + (name 'guix-build-coordinator-queue-builds) > + (extensions > + (list > + (service-extension shepherd-root-service-type > + guix-build-coordinator-queue-builds-shepherd-ser= vices) > + (service-extension activation-service-type > + guix-build-coordinator-queue-builds-activation) > + (service-extension account-service-type > + guix-build-coordinator-queue-builds-account))) > + (description > + "Run the Guix Build Coordinator queue builds script."))) Likewise it=E2=80=99d be great if you could add a few works here. OK to push with these changes, thank you! Ludo=E2=80=99.