From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id fl+4K3dSi1/sAgAA0tVLHw (envelope-from ) for ; Sat, 17 Oct 2020 20:22:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KAsUJ3dSi19FUAAAB5/wlQ (envelope-from ) for ; Sat, 17 Oct 2020 20:22:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF2979402A9 for ; Sat, 17 Oct 2020 20:22:14 +0000 (UTC) Received: from localhost ([::1]:35256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTsiT-0004k6-L8 for larch@yhetil.org; Sat, 17 Oct 2020 16:22:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTsiI-0004jy-3Y for guix-patches@gnu.org; Sat, 17 Oct 2020 16:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTsiH-00033x-QZ for guix-patches@gnu.org; Sat, 17 Oct 2020 16:22:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTsiH-0005hi-M0 for guix-patches@gnu.org; Sat, 17 Oct 2020 16:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44038] [PATCH] Fix deprecation warning for origin-sha256 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 Oct 2020 20:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44038 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Helio Machado <0x2b3bfa0@gmail.com> Cc: 44038@debbugs.gnu.org Received: via spool by 44038-submit@debbugs.gnu.org id=B44038.160296611421914 (code B ref 44038); Sat, 17 Oct 2020 20:22:01 +0000 Received: (at 44038) by debbugs.gnu.org; 17 Oct 2020 20:21:54 +0000 Received: from localhost ([127.0.0.1]:35605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTsiA-0005hO-2s for submit@debbugs.gnu.org; Sat, 17 Oct 2020 16:21:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTsi8-0005h9-Nj for 44038@debbugs.gnu.org; Sat, 17 Oct 2020 16:21:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33128) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTsi3-00032y-GF; Sat, 17 Oct 2020 16:21:47 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40694 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kTsi3-00037X-4A; Sat, 17 Oct 2020 16:21:47 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sat, 17 Oct 2020 22:21:45 +0200 In-Reply-To: (Helio Machado's message of "Fri, 16 Oct 2020 18:14:29 +0200") Message-ID: <87y2k44n8m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: mgcNagjIunW6 Hi, Helio Machado <0x2b3bfa0@gmail.com> skribis: > This patch fixes the following build-time deprecation warning: > > guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, > use 'origin-hash' instead Thanks for looking into it! The deprecation warning is a bit confusing though in this case because =E2=80=98origin-hash=E2=80=99 is not exactly a = drop-in replacement for =E2=80=98origin-sha256=E2=80=99, as can be seen in the manu= al, so this patch wouldn=E2=80=99t have the desired effect. Instead, =E2=80=98print.scm=E2=80=99 could be changed to emit a (sha256 =E2= =80=A6) form when the object is indeed a sha256 hash, and otherwise use a (hash =E2=80=A6) form. See . Thanks, Ludo=E2=80=99.