unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Helio Machado <0x2b3bfa0@gmail.com>
Cc: 44038@debbugs.gnu.org
Subject: [bug#44038] [PATCH] Fix deprecation warning for origin-sha256
Date: Sat, 17 Oct 2020 22:21:45 +0200	[thread overview]
Message-ID: <87y2k44n8m.fsf@gnu.org> (raw)
In-Reply-To: <CANe01w5vyRSF2ZqycmR2CukB_DXpJHYLQix-Ao+nAg5B=ECPWw@mail.gmail.com> (Helio Machado's message of "Fri, 16 Oct 2020 18:14:29 +0200")

Hi,

Helio Machado <0x2b3bfa0@gmail.com> skribis:

> This patch fixes the following build-time deprecation warning:
>
>     guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated,
> use 'origin-hash' instead

Thanks for looking into it!  The deprecation warning is a bit confusing
though in this case because ‘origin-hash’ is not exactly a drop-in
replacement for ‘origin-sha256’, as can be seen in the manual, so this
patch wouldn’t have the desired effect.

Instead, ‘print.scm’ could be changed to emit a (sha256 …) form when the
<content-hash> object is indeed a sha256 hash, and otherwise use a (hash
…) form.

See
<https://guix.gnu.org/manual/devel/en/html_node/origin-Reference.html#index-content_002dhash>.

Thanks,
Ludo’.




  reply	other threads:[~2020-10-17 20:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 16:14 [bug#44038] [PATCH] Fix deprecation warning for origin-sha256 Helio Machado
2020-10-17 20:21 ` Ludovic Courtès [this message]
2020-10-18 22:25   ` Helio Machado
2020-10-19  8:57     ` bug#44038: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2k44n8m.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=0x2b3bfa0@gmail.com \
    --cc=44038@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).