From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kFTcAomctV+/XAAA0tVLHw (envelope-from ) for ; Wed, 18 Nov 2020 22:13:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KANKOoictV+XUQAAB5/wlQ (envelope-from ) for ; Wed, 18 Nov 2020 22:13:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 641049402A0 for ; Wed, 18 Nov 2020 22:13:28 +0000 (UTC) Received: from localhost ([::1]:57358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfVhe-0001iK-90 for larch@yhetil.org; Wed, 18 Nov 2020 17:13:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfVhG-0001hq-57 for guix-patches@gnu.org; Wed, 18 Nov 2020 17:13:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfVhF-0007U6-SA for guix-patches@gnu.org; Wed, 18 Nov 2020 17:13:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kfVhF-00070T-LD for guix-patches@gnu.org; Wed, 18 Nov 2020 17:13:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44089] [PATCH] gnu: Add emacs-wucuo. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Nov 2020 22:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44089 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Joseph LaFreniere , 44089@debbugs.gnu.org Cc: Nicolas Goaziou Received: via spool by 44089-submit@debbugs.gnu.org id=B44089.160573754926864 (code B ref 44089); Wed, 18 Nov 2020 22:13:01 +0000 Received: (at 44089) by debbugs.gnu.org; 18 Nov 2020 22:12:29 +0000 Received: from localhost ([127.0.0.1]:36842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfVgi-0006zE-Uj for submit@debbugs.gnu.org; Wed, 18 Nov 2020 17:12:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfVgg-0006z0-RT for 44089@debbugs.gnu.org; Wed, 18 Nov 2020 17:12:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35670) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfVgb-0007Re-Ka; Wed, 18 Nov 2020 17:12:21 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35500 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kfVgZ-0007vb-Ul; Wed, 18 Nov 2020 17:12:20 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <878sc1k27o.fsf@odyssey.lafreniere.xyz> <878sc18aw5.fsf@nicolasgoaziou.fr> Date: Wed, 18 Nov 2020 23:12:18 +0100 In-Reply-To: <878sc18aw5.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 20 Oct 2020 12:11:38 +0200") Message-ID: <87y2iyiabh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.8 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: ZDoxohXH/HlC Hi Joseph, A friendly reminder. :-) https://issues.guix.gnu.org/44089 Ludo=E2=80=99. Nicolas Goaziou skribis: > Hello, > > Joseph LaFreniere writes: > >> Subject: [PATCH] gnu: Add emacs-wucuo. >> >> * gnu/packages/emacs-xyz.scm (emacs-wucuo): New variable. > > Thank you. Some comments follow. > >> + (version "0.2.7") > > Based on your feedback, upstream released 0.2.8 a few hours ago. > >> + (sha256 >> + (base32 >> + "1iw4jdlqvki95gh7bzl7hjidc2kz9qyc1zjd7klh63gvk0z09700")))) > > Nitpick: please move the string on the same line as `base32'. > >> + (build-system emacs-build-system) >> + (home-page "https://github.com/redguardtoo/wucuo") >> + (synopsis >> + "Fastest solution to spell check camel case code or plain text") > > Please move the string on the same line as `synopsis'. Also, "fastest" > sounds like a buzzword. I think "Fast" would be more neutral. > >> + (description >> + "This package provides a spell checker on top of either aspell or >> +hunspell. >> + >> +@itemize >> +@item @code{wucuo-spell-check-file} will spell check one file and repor= t its >> +typos >> +@item If @code{wucuo-flyspell-start-mode} is \"normal\", @code{wucuo-st= art} >> +runs @code{flyspell-buffer}. If it's \"normal\", @code{wucuo-start} ru= ns >> +@code{flyspell-region} to check visible region in current window. >> +@item The interval of checking is set by @code{wucuo-update-interval} >> +@end itemize >> + >> +See @code{wucuo-check-nil-font-face} on how to check plain text (text w= ithout >> +font) >> +@itemize >> +@item Use @code{wucuo-current-font-face} to detect font face at point >> +@item If @code{wucuo-flyspell-start-mode} is \"normal\", >> +@code{wucuo-spell-check-buffer-max} specifies the maximum size of buffe= r to >> +check. If @code{wucuo-flyspell-start-mode} is \"fast\", >> +@code{wucuo-spell-check-region-max} specifies the maximum size of visib= le >> +region to check. >> +@item You can define a function in @code{wucuo-spell-check-buffer-predi= cate}. >> +If the function returns t, the spell checking of current buffer will co= ntinue. >> +If it returns nil, the spell checking is skipped. >> +@end itemize >> + >> +Here is sample to skip checking in specified major modes, >> +@lisp >> + (setq wucuo-spell-check-buffer-predicate >> + (lambda () >> + (not (memq major-mode >> + '(dired-mode >> + log-edit-mode >> + compilation-mode >> + help-mode >> + profiler-report-mode >> + speedbar-mode >> + gud-mode >> + calc-mode >> + Info-mode))))) >> +@end lisp") > > I think most of this belongs to the manual, not to the description. What > about: > > This package provides a spell checker on top of either Aspell or > Hunspell, and relies on Flyspell internally. It operates on the > current region or buffer, a file, or a complete directory. > > Could you send an updated patch? > > Regards,