From: "Ludovic Courtès" <ludo@gnu.org>
To: Joseph LaFreniere <joseph@lafreniere.xyz>, 44089@debbugs.gnu.org
Cc: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: [bug#44089] [PATCH] gnu: Add emacs-wucuo.
Date: Wed, 18 Nov 2020 23:12:18 +0100 [thread overview]
Message-ID: <87y2iyiabh.fsf@gnu.org> (raw)
In-Reply-To: <878sc18aw5.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 20 Oct 2020 12:11:38 +0200")
Hi Joseph,
A friendly reminder. :-)
https://issues.guix.gnu.org/44089
Ludo’.
Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:
> Hello,
>
> Joseph LaFreniere <joseph@lafreniere.xyz> writes:
>
>> Subject: [PATCH] gnu: Add emacs-wucuo.
>>
>> * gnu/packages/emacs-xyz.scm (emacs-wucuo): New variable.
>
> Thank you. Some comments follow.
>
>> + (version "0.2.7")
>
> Based on your feedback, upstream released 0.2.8 a few hours ago.
>
>> + (sha256
>> + (base32
>> + "1iw4jdlqvki95gh7bzl7hjidc2kz9qyc1zjd7klh63gvk0z09700"))))
>
> Nitpick: please move the string on the same line as `base32'.
>
>> + (build-system emacs-build-system)
>> + (home-page "https://github.com/redguardtoo/wucuo")
>> + (synopsis
>> + "Fastest solution to spell check camel case code or plain text")
>
> Please move the string on the same line as `synopsis'. Also, "fastest"
> sounds like a buzzword. I think "Fast" would be more neutral.
>
>> + (description
>> + "This package provides a spell checker on top of either aspell or
>> +hunspell.
>> +
>> +@itemize
>> +@item @code{wucuo-spell-check-file} will spell check one file and report its
>> +typos
>> +@item If @code{wucuo-flyspell-start-mode} is \"normal\", @code{wucuo-start}
>> +runs @code{flyspell-buffer}. If it's \"normal\", @code{wucuo-start} runs
>> +@code{flyspell-region} to check visible region in current window.
>> +@item The interval of checking is set by @code{wucuo-update-interval}
>> +@end itemize
>> +
>> +See @code{wucuo-check-nil-font-face} on how to check plain text (text without
>> +font)
>> +@itemize
>> +@item Use @code{wucuo-current-font-face} to detect font face at point
>> +@item If @code{wucuo-flyspell-start-mode} is \"normal\",
>> +@code{wucuo-spell-check-buffer-max} specifies the maximum size of buffer to
>> +check. If @code{wucuo-flyspell-start-mode} is \"fast\",
>> +@code{wucuo-spell-check-region-max} specifies the maximum size of visible
>> +region to check.
>> +@item You can define a function in @code{wucuo-spell-check-buffer-predicate}.
>> +If the function returns t, the spell checking of current buffer will continue.
>> +If it returns nil, the spell checking is skipped.
>> +@end itemize
>> +
>> +Here is sample to skip checking in specified major modes,
>> +@lisp
>> + (setq wucuo-spell-check-buffer-predicate
>> + (lambda ()
>> + (not (memq major-mode
>> + '(dired-mode
>> + log-edit-mode
>> + compilation-mode
>> + help-mode
>> + profiler-report-mode
>> + speedbar-mode
>> + gud-mode
>> + calc-mode
>> + Info-mode)))))
>> +@end lisp")
>
> I think most of this belongs to the manual, not to the description. What
> about:
>
> This package provides a spell checker on top of either Aspell or
> Hunspell, and relies on Flyspell internally. It operates on the
> current region or buffer, a file, or a complete directory.
>
> Could you send an updated patch?
>
> Regards,
next prev parent reply other threads:[~2020-11-18 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 3:26 [bug#44089] [PATCH] gnu: Add emacs-wucuo Joseph LaFreniere
2020-10-20 10:11 ` Nicolas Goaziou
2020-11-18 22:12 ` Ludovic Courtès [this message]
2021-05-08 21:32 ` Joseph LaFreniere
2021-05-14 21:52 ` bug#44089: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2iyiabh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44089@debbugs.gnu.org \
--cc=joseph@lafreniere.xyz \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).