From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Qp6QNtnQEWBlEgAA0tVLHw (envelope-from ) for ; Wed, 27 Jan 2021 20:45:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kKFBMtnQEWA6PAAA1q6Kng (envelope-from ) for ; Wed, 27 Jan 2021 20:45:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED39D940503 for ; Wed, 27 Jan 2021 20:45:12 +0000 (UTC) Received: from localhost ([::1]:48598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4rgd-00012Y-NL for larch@yhetil.org; Wed, 27 Jan 2021 15:45:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4rgU-00012I-T6 for guix-patches@gnu.org; Wed, 27 Jan 2021 15:45:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4rgU-0004Yr-Lu for guix-patches@gnu.org; Wed, 27 Jan 2021 15:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4rgU-0002mX-KL for guix-patches@gnu.org; Wed, 27 Jan 2021 15:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46139] [PATCH] gnu: Add tpm2-tss. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Jan 2021 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46139 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46139@debbugs.gnu.org X-Debbugs-Original-To: guix-patches--- via X-Debbugs-Original-Cc: =?UTF-8?Q?L=C3=A9o?= Le Bouter , 46139@debbugs.gnu.org Received: via spool by 46139-submit@debbugs.gnu.org id=B46139.161178027210618 (code B ref 46139); Wed, 27 Jan 2021 20:45:02 +0000 Received: (at 46139) by debbugs.gnu.org; 27 Jan 2021 20:44:32 +0000 Received: from localhost ([127.0.0.1]:46247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4rfz-0002lC-UU for submit@debbugs.gnu.org; Wed, 27 Jan 2021 15:44:32 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:40677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4rfx-0002ky-VG for 46139@debbugs.gnu.org; Wed, 27 Jan 2021 15:44:30 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B40A224000C; Wed, 27 Jan 2021 20:44:22 +0000 (UTC) From: Nicolas Goaziou References: <20210127184227.29258-1-lle-bout@zaclys.net> Date: Wed, 27 Jan 2021 21:44:21 +0100 In-Reply-To: <20210127184227.29258-1-lle-bout@zaclys.net> (guix-patches@gnu.org's message of "Wed, 27 Jan 2021 19:42:27 +0100") Message-ID: <87y2geqfdm.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: ED39D940503 X-Spam-Score: -2.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: rSdkvkP8Z7/+ Hello, guix-patches--- via writes: > * gnu/packages/hardware.scm (tpm2-tss): New variable. Thank you. Some comments follow. > + (inputs > + `(("pkg-config" ,pkg-config) > + ("openssl" ,openssl) > + ("json-c" ,json-c) > + ("curl" ,curl))) pkg-config should be a native-input. Don't you need libgcrypt as an input, too? > + (synopsis "OSS implementation of the TCG TPM2 Software Stack (TSS2)") > + (description "This package provides the Trusted Computing Group's (TCG) > +TPM2 Software Stack (TSS). This stack consists of the following layers from > +top to bottom: > + > +@enumerate > +@item Feature API (FAPI) as described in the TCG Feature API (FAPI) > +Specification along with TCG TSS 2.0 JSON Data Types and Policy Language > +Specification This API is designed to be very high-level API, intended to make > +programming with the TPM as simple as possible. The API functions are exposed > +through a single library: libtss2-fapi. > +@item Enhanced System API (ESAPI) as described in the TCG TSS 2.0 Enhanced > +System API (ESAPI) Specification This API is a 1-to-1 mapping of the TPM2 > +commands documented in Part 3 of the TPM2 specification. Additionally there > +are asynchronous versions of each command. In addition to SAPI, the ESAPI > +performs tracking of meta data for TPM object and automatic calculation of > +session based authorization and encryption values. Both the synchronous and > +asynchronous API are exposed through a single library: libtss2-esys. > +@item System API (SAPI) as described in the TCG TSS 2.0 System Level API > +(SAPI) Specification This API is a 1-to-1 mapping of the TPM2 commands > +documented in Part 3 of the TPM2 specification. Additionally there are > +asynchronous versions of each command. These asynchronous variants may be > +useful for integration into event-driven programming environments. Both the > +synchronous and asynchronous API are exposed through a single library: > +libtss2-sys. > +@item Marshaling/Unmarshaling (MU) as described in the TCG TSS 2.0 > +Marshaling/Unmarshaling API Specification This API provides a set of > +marshaling and unmarshaling functions for all data types define by the TPM > +library specification. The Marshaling/Unmarshaling API is exposed through a > +library called libtss2-mu. > +@item TPM Command Transmission Interface (TCTI) as described in the TCG TSS > +2.0 TPM Command Transmission Interface (TCTI) API Specification. This API > +provides a standard interface to transmit / receive TPM command / response > +buffers. It is expected that any number of libraries implementing the TCTI API > +will be implemented as a way to abstract various platform specific IPC > +mechanisms. Currently this repository provides several TCTI implementations: > +libtss2-tcti-device, libtss2-tcti-tbs (for Windows), libtss2-tcti-swtpm and > +libtss2-tcti-mssim. The former should be used for direct access to the TPM > +through the Linux kernel driver. The latter implements the protocol exposed by > +the Microsoft software TPM2 simulator. > +@item The TCG TSS 2.0 Overview and Common Structures Specification forms the > +basis for all implementations in this project. NOTE: We deviate from this > +specification by increasing the value of TPM2_NUM_PCR_BANKS from 3 to 16 to > +ensure compatibility with TPM2 implementations that have enabled a larger than > +typical number of PCR banks. This larger value for TPM2_NUM_PCR_BANKS is > +expected to be included in a future revision of the specification. > +@end enumerate") This description is waaaaay too long. Could you trim it down a bit? IIRC, the manual suggests description of about 5 lines. Of course, this is not a hard rule. Also you need to add two spaces after sentences. > + (home-page "https://tpm2-software.github.io/") Could you move it above synopsis? Regards, -- Nicolas Goaziou