[bug#46697] [PATCH] Added capstone 4.

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Gerd Heber <gerd.heber@gmail.com> writes:

>  gnu/packages/engineering.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

Thank you for your patch! Some comments follow.

First, there is already a capstone package in Guix, at version 3.5. Is
there a particular reason for not updating it instead of creating a new
variable?

> +     (uri (string-append "https://github.com/aquynh/capstone"
> +                         "/archive/" version ".tar.gz"))

This URI is unstable. We prefer using tagged commits instead. See for
example already defined capstone package.

> +      #:tests? #t))

This is the default, so it can be omitted.

> +   (home-page "https://www.capstone-engine.org")
> +   (synopsis "Lightweight multi-platform, multi-architecture disassembly framework")

Nitpick: I would remove multi-platform, since it makes little sense from
Guix POV.

> +   (description
> +    "Capstone is a lightweight multi-platform, multi-architecture disassembly

Ditto.

> +framework. Capstone can disassemble machine code for many supported

You need to add two spaces after full stops.

> +architectures such as x86, x86_64, arm, arm64, mips, ppc, sparc, sysz and
> +xcore. It provides bindings for Python, Java, OCaml and more.")

Also, could you provide a proper commit message, for example

    gnu: capstone: Update to 4.0.2.

    * gnu/packages/engineering.scm (capstone): Update to 4.0.2.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou