unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: Leo Prikler <leo.prikler@student.tugraz.at>, 47027@debbugs.gnu.org
Subject: [bug#47027] Disarchive package
Date: Sun, 21 Mar 2021 11:29:00 +0100	[thread overview]
Message-ID: <87y2eg3imr.fsf_-_@gnu.org> (raw)
In-Reply-To: <875z1ws4mc.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 12 Mar 2021 17:45:15 +0100")

Ping!  :-)

Ludovic Courtès <ludo@gnu.org> skribis:

> Hello!
>
> Timothy Sample <samplet@ngyro.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Leo Prikler <leo.prikler@student.tugraz.at> skribis:
>>>
>>>> I've checked and the package seems to build fine with Guile 3.0.2.  I
>>>> think the bytecode mismatch happens, because Guix compiles stuff with
>>>> 3.0.2 by default, but users have 3.0.5 in their system, which is not
>>>> bytecode-compatible.  (As an exception, Guix itself seems to be
>>>> compiled with Guile 3.0.5 for performance reasons).
>>>>
>>>> I think it would be fine to add with Guile 3.0.2, perhaps adding a note
>>>> that Guile 3.0.5 will effectively be required to use Guix interop?  If
>>>> not, could you provide a script, that breaks in a way other than
>>>> recompiling the mismatching code?
>>>
>>> I tend to agree here: I don’t think ‘guile-3.0-latest’ is needed in this
>>> case.  The only case where you need it is if it depends on a library,
>>> such as Guix, that is itself built with ‘guile-3.0-latest’.
>>
>> Well, now I’m second guessing myself.  :)
>>
>> It is just the auto compilation notes and warnings that I’m worried
>> about.  The module closure of “swh.scm” works fine on Guile 3.0.2.
>>
>> Eventually, the daemon will invoke Disarchive via “builtin:download” and
>> “perform-download.scm”.  I intend to use the Scheme interface there,
>> which means Disarchive will be runing on Guile 3.0.5.  For that, it
>> would be preferable to have a Guile 3.0.5 version of Disarchive, right?
>
> No, that’s fine.  Guile 3.0.5 can run 3.0.2 bytecode without any
> warnings; what yields warnings is doing it the other way around.
> Anyway, we can always revisit this if problems come up.
>
>> On the other hand, when using Disarchive to extract metadata (e.g., with
>> Cuirass), the SWH code is not needed at all.
>>
>> I will resurrect my patch for calling Disarchive from Guix, and come
>> back to this when I know exactly what kind of package I need for that to
>> work smoothly.
>
> Yay!
>
>>>> As far as the location is concerned, I personally do not like adding
>>>> too many single-package files.  Would it make sense to add this to
>>>> compression.scm (like gzip) or backup.scm (like libarchive)?
>>>
>>> Maybe there’ll be other packages eventually in archival.scm, like the
>>> SWH Python code?  It’s fine with me, but I don’t have a strong opinion.
>>
>> I don’t feel strongly about it either.  There’s other software besides
>> Disarchive and SWH that could be called “archival”, and I think it’s
>> more accurate than the other options.
>
> Dunno maybe you can do as Leo suggests by putting it in guile-xyz.scm or
> some such.
>
> Thanks!
>
> Ludo’.




  reply	other threads:[~2021-03-21 10:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 19:37 [bug#47027] Disarchive package Timothy Sample
2021-03-09 19:39 ` [bug#47027] [PATCH 1/2] gnu: Add guile-quickcheck Timothy Sample
2021-03-09 19:39   ` [bug#47027] [PATCH 2/2] gnu: Add disarchive Timothy Sample
2021-03-10 10:23     ` Leo Prikler
2021-03-11 22:17       ` [bug#47027] Disarchive package Ludovic Courtès
2021-03-11 22:43         ` Tobias Geerinckx-Rice via Guix-patches via
2021-03-12  3:06         ` Timothy Sample
2021-03-12 10:08           ` Leo Prikler
2021-03-12 16:45           ` Ludovic Courtès
2021-03-21 10:29             ` Ludovic Courtès [this message]
2021-03-21 11:10               ` Leo Prikler
2021-03-21 14:13                 ` Timothy Sample
2021-03-21 14:59                   ` Maxime Devos
2021-03-21 16:59                   ` Ludovic Courtès
2021-03-23  4:45                     ` bug#47027: " Timothy Sample
2021-03-23 11:01                       ` [bug#47027] " Ludovic Courtès
2021-03-10 10:00   ` [bug#47027] [PATCH 1/2] gnu: Add guile-quickcheck Leo Prikler
2021-03-14 21:12   ` Maxime Devos
2021-03-17 20:52     ` [bug#47027] Disarchive package Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2eg3imr.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=47027@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    --cc=samplet@ngyro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).