From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QORvKvoQZmD8NAEAgWs5BA (envelope-from ) for ; Thu, 01 Apr 2021 20:29:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id IF5JJPoQZmCEYgAAbx9fmQ (envelope-from ) for ; Thu, 01 Apr 2021 18:29:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9B9278861 for ; Thu, 1 Apr 2021 20:29:13 +0200 (CEST) Received: from localhost ([::1]:57426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lS248-0004yi-OM for larch@yhetil.org; Thu, 01 Apr 2021 14:29:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS1sM-0004UB-Mz for guix-patches@gnu.org; Thu, 01 Apr 2021 14:17:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lS1sM-0004hk-Fg for guix-patches@gnu.org; Thu, 01 Apr 2021 14:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lS1sM-0007ky-Aj for guix-patches@gnu.org; Thu, 01 Apr 2021 14:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47539] [PATCH 00/28] Add gh and dependencies Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Apr 2021 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47539 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler , 47539@debbugs.gnu.org Received: via spool by 47539-submit@debbugs.gnu.org id=B47539.161730098129760 (code B ref 47539); Thu, 01 Apr 2021 18:17:02 +0000 Received: (at 47539) by debbugs.gnu.org; 1 Apr 2021 18:16:21 +0000 Received: from localhost ([127.0.0.1]:58532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS1rh-0007jv-8N for submit@debbugs.gnu.org; Thu, 01 Apr 2021 14:16:21 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:38814 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS1rf-0007jf-Oh for 47539@debbugs.gnu.org; Thu, 01 Apr 2021 14:16:20 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1617300971; bh=5otnlf2n+uheaKpCUKrnDJjXUy91ufePCuZTz7KUW8U=; h=From:To:Subject:In-Reply-To:References:Date; b=QD7AM2ZKGmHyC0gCE1Jn18XpteYFYNKaj8x/YL2t7rmFM1mg/nNGRdzK1U7FRdNIU bqXlXTrpC1WMdoMMlp3AePUegRpbuIllybpDwhNbawudvPiGGMRJTfQyROARvPZnXL //LjTtj0dZ4EeMzhdbtbrrlYybu44mQxPhrgaeKM= In-Reply-To: References: <7f41ded1648030ed8f4db3165bfe4ccb2cb6b2a9.camel@student.tugraz.at> <87czve3vrg.fsf@yoctocell.xyz> <877dlm3rak.fsf@yoctocell.xyz> <871rbt519u.fsf@yoctocell.xyz> Date: Thu, 01 Apr 2021 20:16:11 +0200 Message-ID: <87y2e13m6s.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617301754; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IqAqqvfcFQAdtJSuaz/zQ/fZKlBdxuZJAB876QvHG7I=; b=IxzrHVMDSL9E1ZAqjMQVeYZCD+Y2HqABIWdPzQe14NE9oWT48NWclzoncNlHyRHcAadfef W1uo88b03RfRcOAAGBqDyToFiNrnOL4a5u50Qx1qND0KVqxUEOZ89lTr9wrq78rYNJCztQ SWKwknIcrtIRIVbFw2sOdkUjTHPx1oHad4YiBPKpi33illg530rHxsSxSE6rn6es+WbC+S peu3yqMQoobz2AiiCIPrjY5aw3p0qrOxg4Gp8ZiJW8hFzGX/LYfInJV0lL/eatw/sMq0/D yciKuJS0ToNGynMn0mrYNhZwir7G/BwSJbmZeqsXAooDuVI7MF416SjYmrOZjg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617301754; a=rsa-sha256; cv=none; b=EKci0lDQ9bw5aPhD7mOJdM5NKF6n9Wvt+RJWMesQhkcSzhsy19hgGE1hI6Ajzb0tgF063a 6I6UkEoeDjrVF2EJwkbQLt8SAZJr0TvY4mtIKKOqE4urFjXTxDX+eDXbm637cKsGohBBmA vbQTRLPV/I5Xgc70tu2kaHAqL3ee4xLMpnWuDWsQ/UvHgpmtCKX976+0ZW8fz3ZPMwa1K9 Nj1tgJnUvkmoAuuKnqPSzMcWefC4vup/0qsWukNwWlK6FFZnyf6IaFefgqmqLmMDB8uLnF mGWPIM5VyRGbDfU5DHpY0vDrYIfJvZjByQkpNKVWSBdVtX9PgDahtD7kQoiecQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=QD7AM2ZK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=QD7AM2ZK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9B9278861 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: YYqBKtUg8BfZ On Thu, Apr 01 2021, Leo Prikler wrote: > Am Donnerstag, den 01.04.2021, 20:05 +0200 schrieb Xinglu Chen: >> >> Thank you for the pointer, I managed to get it to work with the >> following snippet: >> >> #+begin_src scheme >> (add-after 'unpack 'remove-safeexec >> (lambda* (#:key outputs #:allow-other-keys) >> (let ((prefix-file (lambda (file) >> (string-append "src/github.com/cli/cli/" >> file)))) >> ;; 'github.com/cli/safeexec' is only used for Windows, >> we >> ;; replace it with the regular 'os/exec'. See >> ;; for discussion. >> (substitute* (map prefix-file >> '("pkg/cmd/alias/expand/expand.go" >> "script/build.go")) >> (("github.com/cli/safeexec") "os/exec") >> (("safeexec") "exec")) >> ;; These files have already imported 'os/exec', >> meaning that >> ;; 'os/exec' would get imported twice, causing an >> error. >> ;; Instead, we just remove the >> 'github.com/cli/safeexec'. >> (substitute* (map prefix-file >> '("cmd/gh/main.go" >> "git/git.go" >> "pkg/iostreams/iostreams.go" >> "pkg/cmd/auth/shared/ssh_keys.go" >> "pkg/cmd/pr/checkout/checkout.go" >> "pkg/cmdutil/web_browser.go" >> "pkg/surveyext/editor_manual.go")) >> (("\"github.com/cli/safeexec\"") "") >> (("safeexec") "exec"))))) >> #+end_src > This should probably be implemented with directory excursions, but > other than that if it works for you, then LGTM :) Ah, I didn't know about that. Thanks for pointing this out. :)