From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: francois.joulaud@radiofrance.com, 48230-done@debbugs.gnu.org
Subject: bug#48230: [PATCH] tests: go: Rename and fix duplicate test.
Date: Wed, 05 May 2021 01:03:54 -0400 [thread overview]
Message-ID: <87y2ctkc05.fsf@gmail.com> (raw)
In-Reply-To: <20210504205548.4232-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 4 May 2021 22:55:48 +0200")
Hi Tobias!
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> * tests/go.scm: Rename "go-version omited 'v' character" to
> "go-version without 'v' prefix" and change the code to match.
> ---
>
> Hi all,
>
> Found on a typo hunt.
Eh, thank you!
> This is my best-effort guess at what was intended. Maybe I'm
> mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to
> "v1.0.2" instead? Let me know!
I wasn't sure anymore, so I looked at the code; go-version->git-ref is a
no-op (leaves the version string intact) unless it matches
%go-pseudo-version-rx.
> tests/go.scm | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/go.scm b/tests/go.scm
> index c33a834f69..565a0d451d 100644
> --- a/tests/go.scm
> +++ b/tests/go.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright 2021 Franois Joulaud <francois.joulaud@radiofrance.com>
> +;;; Copyright 2021 Tobias Geerinckx-Rice <me@tobias.gr>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
> "v1.0.2"
> (go-version->git-ref "v1.0.2"))
>
> -(test-equal "go-version omited 'v' character"
> - "v1.0.2"
> - (go-version->git-ref "v1.0.2"))
> +(test-equal "go-version without 'v' prefix"
> + "1.0.2"
> + (go-version->git-ref "1.0.2"))
That test doesn't have much value based on my above analysis. I suggest
we drop it; it's testing the same thing as the "v1.0.2" case.
I've removed it and pushed with commit 2354d79b88.
Thank you!
Maxim
prev parent reply other threads:[~2021-05-05 5:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 20:55 [bug#48230] [PATCH] tests: go: Rename and fix duplicate test Tobias Geerinckx-Rice via Guix-patches via
2021-05-05 5:03 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2ctkc05.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=48230-done@debbugs.gnu.org \
--cc=francois.joulaud@radiofrance.com \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).